refactor(starknet_integration_tests): add TestScenario to enable testing different scenarios #3795
+64
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Jan 29, 2025
alonh5
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)
crates/starknet_integration_tests/src/utils.rs line 64 at r1 (raw file):
const N_TXS_IN_FIRST_BLOCK: usize = 2; pub enum TestScenario {
Looks like a test scenario should actually be a trait?
Yael-Starkware
force-pushed
the
yael/create_first_block_txs
branch
from
f6f3c8b to
72d83ce
Compare
Yael-Starkware
commented
Feb 2, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @alonh5)
crates/starknet_integration_tests/src/utils.rs line 64 at r1 (raw file):
Previously, alonh5 (Alon Haramati) wrote…
Looks like a test scenario should actually be a trait?
great idea, thanks!
done.
Yael-Starkware
force-pushed
the
yael/integration_test_test_scenarios
branch
3 times, most recently
from
e58d457 to
65c0136
Compare
Yael-Starkware
changed the base branch from
yael/create_first_block_txs
to
main
…ing different scenarios
Yael-Starkware
force-pushed
the
yael/integration_test_test_scenarios
branch
from
65c0136 to
df1764f
Compare
alonh5
approved these changes
Feb 2, 2025
There was a problem hiding this comment.
Reviewed 216 of 216 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.