test(starknet_integration_tests): add deploy_tx to the integration test

[Yael-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Yael-Starkware]

• refactor(starknet_integration_tests): refactor the check that nonces are synced #3805
• test(starknet_integration_tests): add deploy_tx to the integration test #3803 👈 (View in Graphite)
• refactor(starknet_integration_tests): add TestScenario to enable testing different scenarios #3795
• feat(starknet_integration_tests): add create_first_block_txs utility #3788
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[alonh5]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)

---

crates/starknet_integration_tests/src/utils.rs line 230 at r2 (raw file):

/// Creates a multi-account transaction generator for the integration test.
pub fn create_integration_test_tx_generator() -> MultiAccountTransactionGenerator {

Why can't you share the logic of the flow test?

Code quote:

a

[Yael-Starkware]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_integration_tests/src/utils.rs line 230 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Why can't you share the logic of the flow test?

Currently the flow test is working differently. it has a deployed accounts and undeployed accounts and is checking very specific scenarios on each. So the setup is different.

I think we should consider having only undeployed accounts also in flow_test. But this should be done separately.

[alonh5]

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @Yael-Starkware)

---

crates/starknet_integration_tests/src/utils.rs line 251 at r4 (raw file):

    for (i, account) in [
        FeatureContract::AccountWithoutValidations(CairoVersion::Cairo1(RunnableCairo1::Casm)),
        FeatureContract::AccountWithoutValidations(CairoVersion::Cairo0),

Are we registering 2 accounts but only using 1?

---

crates/starknet_integration_tests/src/end_to_end_integration.rs line 46 at r4 (raw file):

    // Run the first block scenario to bootstrap the accounts.
    integration_test_manager
        .test_and_verify(tx_generator, 0, FirstBlock, SENDER_ACCOUNT, BlockNumber(2))

Make a const for consistency.

Code quote:

BlockNumber(2)

[Yael-Starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

crates/starknet_integration_tests/src/end_to_end_integration.rs line 46 at r4 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Make a const for consistency.

Done.

---

crates/starknet_integration_tests/src/utils.rs line 251 at r4 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Are we registering 2 accounts but only using 1?

good question, I didn't change this code, I believe we should use both -to test also Cairo0 accounts, and in general we should add multiple accounts.

I can add a monday task to enable this account and also multiple accounts.

[alonh5]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Yael-Starkware)

---

crates/starknet_integration_tests/src/utils.rs line 251 at r4 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

good question, I didn't change this code, I believe we should use both -to test also Cairo0 accounts, and in general we should add multiple accounts.

I can add a monday task to enable this account and also multiple accounts.

Ok, yeah let's add it to monday.
Until then you can really simplify this function.

---

crates/starknet_integration_tests/src/end_to_end_integration.rs line 12 at r5 (raw file):

pub async fn end_to_end_integration(tx_generator: &mut MultiAccountTransactionGenerator) {
    const EXPECTED_SECOND_BLOCK_NUMBER: BlockNumber = BlockNumber(2);

Can we rename these three consts? Something more along the lines of n blocks to wait, that suits the usage better IMO. WDYT?

[Yael-Starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

crates/starknet_integration_tests/src/end_to_end_integration.rs line 12 at r5 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Can we rename these three consts? Something more along the lines of n blocks to wait, that suits the usage better IMO. WDYT?

I agree, I also thought this was confusing but tried to avoid too many changes.

---

crates/starknet_integration_tests/src/utils.rs line 251 at r4 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Ok, yeah let's add it to monday.
Until then you can really simplify this function.

Done.

[alonh5]

Reviewed 4 of 4 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)

---

crates/starknet_integration_tests/src/end_to_end_integration.rs line 12 at r5 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

I agree, I also thought this was confusing but tried to avoid too many changes.

Try BLOCK_TO_WAIT_FOR_BOOTSTRAP, BLOCK_TO_WAIT_FOR_FIRST_ROUND, BLOCK_TO_WAIT_FOR_LATE_NODE
Also change the trait impl FirstBlock to somthing like Bootstrap/DeployAccount

[Yael-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_integration_tests/src/end_to_end_integration.rs line 12 at r5 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Try BLOCK_TO_WAIT_FOR_BOOTSTRAP, BLOCK_TO_WAIT_FOR_FIRST_ROUND, BLOCK_TO_WAIT_FOR_LATE_NODE
Also change the trait impl FirstBlock to somthing like Bootstrap/DeployAccount

Done.

[alonh5]

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)

---

crates/starknet_integration_tests/src/end_to_end_integration.rs line 12 at r5 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

Done.

What about the trait impl?

[Yael-Starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_integration_tests/src/end_to_end_integration.rs line 12 at r5 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

What about the trait impl?

oh sorry, I missed that.
done.

[alonh5]

Reviewed 2 of 2 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)