chore(consensus): add height and round parameters to ConsensusConfig #3928
Conversation
|
This change is |
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @guy-starkware)
crates/starknet_consensus/src/config.rs line 36 at r1 (raw file):
pub future_height_limit: u32, /// How many rounds in the future should we cache. pub future_round_limit: u32,
future_round_limit - should be for the current round.
I think we should also add future_height_round_limit, and default to 1.
Code quote:
/// How many heights in the future should we cache.
pub future_height_limit: u32,
/// How many rounds in the future should we cache.
pub future_round_limit: u32,
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @guy-starkware)
crates/starknet_consensus/src/config.rs line 36 at r1 (raw file):
Previously, matan-starkware wrote…
future_round_limit - should be for the current round.
I think we should also add future_height_round_limit, and default to 1.
future_height_round_limit = the number of rounds to cache to for future heights
guy-starkware
force-pushed
the
guyn/config/remove_stuff_from_consensus_config
branch
from
445a40e to
edf2e86
Compare
guy-starkware
force-pushed
the
guyn/config/add_height_params_to_consensus_config
branch
from
3c5e48c to
53a727f
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @matan-starkware)
crates/starknet_consensus/src/config.rs line 36 at r1 (raw file):
Previously, matan-starkware wrote…
future_height_round_limit = the number of rounds to cache to for future heights
Done.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @asmaastarkware)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
guy-starkware
changed the base branch from
guyn/config/remove_stuff_from_consensus_config
to
main
Merge activity
|
guy-starkware
force-pushed
the
guyn/config/add_height_params_to_consensus_config
branch
from
53a727f to
b38e144
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:
No description provided.