chore(consensus): remove some fields from ConsensusConfig

[guy-starkware]

Remove some fields that were on ConsensusConfig that were no longer needed.

[reviewable-StarkWare]

This change is 

[guy-starkware]

• chore(consensus): reorder config item #3430
• chore(consensus): move some network parameter consts into config #3380
• chore(consensus): add height and round parameters to ConsensusConfig #3928
• chore(consensus): remove some fields from ConsensusConfig #3379 👈 (View in Graphite)
• chore(consensus): update ConsensusManagerConfig with new parameters #3340 : 1 other dependent PR (#3377 )
• chore(consensus): add ContextConfig to SequencerConcensusContext #3634
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[asmaastarkware]

Reviewed 1 of 10 files at r1, 27 of 27 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware and @matan-starkware)

---

crates/starknet_consensus/src/config.rs line 82 at r2 (raw file):

        Self {
            validator_id: ValidatorId::from(DEFAULT_VALIDATOR_ID),
            // start_height: BlockNumber::default(),

delete

[guy-starkware]

Reviewable status: 10 of 28 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @matan-starkware)

---

crates/starknet_consensus/src/config.rs line 82 at r2 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

delete

Done.

[asmaastarkware]

Reviewed 18 of 18 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @matan-starkware)

[matan-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)

---

crates/starknet_consensus/src/config.rs line 36 at r3 (raw file):

    pub future_height_limit: u32,
    /// How many rounds in the future should we cache.
    pub future_round_limit: u32,

Adding these doesn't belong in "remove some fields from ConsensusConfig"

Code quote:

    /// How many heights in the future should we cache.
    pub future_height_limit: u32,
    /// How many rounds in the future should we cache.
    pub future_round_limit: u32,

[guy-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matan-starkware)

---

crates/starknet_consensus/src/config.rs line 36 at r3 (raw file):

Previously, matan-starkware wrote…

Adding these doesn't belong in "remove some fields from ConsensusConfig"

Should I break this into a new PR or rename this one?

[matan-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @guy-starkware)

---

crates/starknet_consensus/src/config.rs line 36 at r3 (raw file):

Previously, guy-starkware wrote…

Should I break this into a new PR or rename this one?

Adding these fields sould be a distinct PR from the removals.

[guy-starkware]

Reviewable status: 25 of 28 files reviewed, 1 unresolved discussion (waiting on @asmaastarkware and @matan-starkware)

---

crates/starknet_consensus/src/config.rs line 36 at r3 (raw file):

Previously, matan-starkware wrote…

Adding these fields sould be a distinct PR from the removals.

I split it into a separate PR.

[matan-starkware]

Reviewed 1 of 10 files at r1, 4 of 27 files at r2, 6 of 6 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)

[matan-starkware]

Reviewed 17 of 18 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @guy-starkware)