chore(consensus): add PapyrusConsensusConfig struct

[guy-starkware]

This creates a new config struct called PapyrusConsensusConfig, which has some fields necessary for running a papyrus node.

Some of it similar to the content of ConsensusManagerConfig, but relevant for the papyrus node instead of the sequencer node.

[reviewable-StarkWare]

This change is 

[guy-starkware]

• chore(consensus): add PapyrusConsensusConfig struct #3377 👈 (View in Graphite)
• chore(consensus): update ConsensusManagerConfig with new parameters #3340 : 1 other dependent PR (#3379 )
• chore(consensus): add ContextConfig to SequencerConcensusContext #3634
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[asmaastarkware]

splitting the consensus config struct is a good step. let's also focus on naming. clear and concise names for each struct and its params will make the code much easier to understand:
ContextConfig: chain_id + num_validators 👍
how did u split the rest?

Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @guy-starkware and @matan-starkware)

---

crates/papyrus_node/src/config/mod.rs line 142 at r2 (raw file):

#[derive(Debug, Clone, Deserialize, Serialize, PartialEq, Validate)]
pub struct PapyrusConsensusConfig {

are u planning to update the ConsensusManagerConfig to use this new struct? or did u forget?

---

crates/papyrus_node/src/run.rs line 209 at r2 (raw file):

    debug!("Context configuration: {context_config:?}");
    let papyrus_consensus_config = papyrus_consensus_config.clone();
    debug!("Papyrus consensus configuration: {papyrus_consensus_config:?}");

Suggestion:

    let consensus_config = consensus_config.clone();
    let context_config = context_config.clone();
    let papyrus_consensus_config = papyrus_consensus_config.clone();
    debug!("Consensus configuration: {consensus_config:?}");
    debug!("Context configuration: {context_config:?}");
    debug!("Papyrus consensus configuration: {papyrus_consensus_config:?}");

[guy-starkware]

I'm not sure what you mean. I generally followed the blueprint Matan sent me for what fields should be in each config.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @asmaastarkware and @matan-starkware)

---

crates/papyrus_node/src/config/mod.rs line 142 at r2 (raw file):

Previously, asmaastarkware (asmaa-starkware) wrote…

are u planning to update the ConsensusManagerConfig to use this new struct? or did u forget?

If I understand Matan's plan correctly, the idea is that ConsensusManagerConfig is used for the manager in starknet_sequencer while PapyrusConsensusConfig is used only in papyrus_node.

---

crates/papyrus_node/src/run.rs line 209 at r2 (raw file):

    debug!("Context configuration: {context_config:?}");
    let papyrus_consensus_config = papyrus_consensus_config.clone();
    debug!("Papyrus consensus configuration: {papyrus_consensus_config:?}");

Done.