chore(papyrus_base_layer): update alloy version towards consolidation #3997
+129
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 6, 2025
ArniStarkware
force-pushed
the
arni/alloy/update_versions
branch
from
0faf271 to
cf3489e
Compare
ArniStarkware
force-pushed
the
arni/alloy/update_versions
branch
from
cf3489e to
5796360
Compare
ArniStarkware
commented
Feb 6, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @guy-starkware)
crates/papyrus_base_layer/src/lib.rs line 73 at r1 (raw file):
pub struct PriceSample { pub timestamp: u64, // Fee is stored as u128 for compatibility with any base layer.
+reviewer:@guy-starkware
Code quote:
// Fee is stored as u128 for compatibility with any base layer.
guy-starkware
approved these changes
Feb 6, 2025
ArniStarkware
force-pushed
the
arni/alloy/update_versions
branch
from
5796360 to
ce33ef7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3999