Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(papyrus_base_layer): consolidate alloy crates #3999

Open
wants to merge 1 commit into
base: arni/alloy/update_versions
Choose a base branch
from

Conversation

ArniStarkware
Copy link
Contributor

@ArniStarkware ArniStarkware commented Feb 6, 2025

Use alloy + features instead of individual crates to consolidate
versioning.
There are no logic changes, only import changes.

Warning: Alloy has tons of features; don't activate features greedily; otherwise, our compilation time will suffer.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

ArniStarkware commented Feb 6, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Feb 6, 2025

@ArniStarkware ArniStarkware force-pushed the arni/alloy/simplify_price_sample_creation branch from 19a0e06 to da1bd03 Compare February 6, 2025 08:15
Copy link

github-actions bot commented Feb 6, 2025

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.744 ms 34.863 ms 35.043 ms]
change: [-4.7557% -3.1903% -1.8185%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) high mild
5 (5.00%) high severe

@ArniStarkware ArniStarkware force-pushed the arni/alloy/consolidate_alloy_crates branch from 7c3a974 to 3db5066 Compare February 6, 2025 08:28
@ArniStarkware ArniStarkware marked this pull request as ready for review February 6, 2025 08:29
@ArniStarkware ArniStarkware force-pushed the arni/alloy/consolidate_alloy_crates branch from 3db5066 to cbd0e44 Compare February 6, 2025 09:40
@ArniStarkware ArniStarkware changed the base branch from arni/alloy/simplify_price_sample_creation to arni/alloy/update_versions February 6, 2025 09:41
@ArniStarkware ArniStarkware force-pushed the arni/alloy/update_versions branch from 5796360 to ce33ef7 Compare February 6, 2025 16:43
@ArniStarkware ArniStarkware force-pushed the arni/alloy/consolidate_alloy_crates branch from cbd0e44 to 75aafa7 Compare February 6, 2025 16:43
Copy link

github-actions bot commented Feb 6, 2025

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.514 ms 35.908 ms 36.392 ms]
change: [+1.7916% +2.8787% +4.1708%] (p = 0.00 < 0.05)
Performance has regressed.
Found 17 outliers among 100 measurements (17.00%)
3 (3.00%) high mild
14 (14.00%) high severe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants