Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(starknet_sequencer_metrics): add infra metric counters and adjust macros to create hash maps #4065

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion


crates/starknet_sequencer_metrics/src/metric_definitions.rs line 135 at r1 (raw file):

        { BATCHER_MSGS_PROCESSED, "batcher_msgs_processed", "Counter of messages  processed by batcher component", 0 },
        { CLASS_MANAGER_MSGS_RECEIVED, "fs_class_manager_msgs_received", "Counter of messages received by class manager component", 0 },
        { CLASS_MANAGER_MSGS_PROCESSED, "fs_class_manager_msgs_processed", "Counter of messages processed by class manager component", 0 },

Please remove this prefix (two locations)

Code quote:

fs_

Copy link
Contributor Author

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/starknet_sequencer_metrics/src/metric_definitions.rs line 135 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please remove this prefix (two locations)

I can't. The short class type name is FsClassManager, so its snake case is: fs_class_manager.

…t macros to create hash maps

commit-id:34419b89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants