Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_sequencer_node,starknet_sequencer_infra): refactor infra metrics #4150

Open
wants to merge 1 commit into
base: spr/main/30292dc9
Choose a base branch
from

Conversation

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link

github-actions bot commented Feb 13, 2025

Artifacts upload workflows:

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 13 files reviewed, 1 unresolved discussion


crates/starknet_sequencer_node/src/metrics.rs line 42 at r1 (raw file):

}

pub fn create_local_servers_metrics() -> LocalServersMetric {

Please change this to a new fn inside an impl block for the struct.

Code quote:

create_local_servers_metrics()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants