Skip to content

feat(apollo_starknet_os_program): hard-code gas costs in constants.cairo #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved


a discussion (no related file):
VersionedConstants does not expose the "components" of syscall gas costs: only the base cost (u64) and linear factor (u64).
To avoid using RawVersionedConstants and duplicating the logic that computes the flat cost from the raw cost components (already done in impl From<RawVersionedConstants> for VersionedConstants), we hard-code the computed costs in constants.cairo.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from d564695 to b1f0aa5 Compare May 2, 2025 14:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 7dd5983 to 3e09a83 Compare May 2, 2025 14:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from b1f0aa5 to 975ab60 Compare May 5, 2025 11:00
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 3e09a83 to 96e007c Compare May 5, 2025 11:00
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from 975ab60 to b565de1 Compare May 5, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 96e007c to 4755ac1 Compare May 5, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from b565de1 to 9291eb0 Compare May 5, 2025 13:09
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 4755ac1 to 38eb8b0 Compare May 5, 2025 13:09
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from 9291eb0 to f692f48 Compare May 6, 2025 12:28
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 38eb8b0 to bc8d7a3 Compare May 6, 2025 12:28
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from f692f48 to d7de69e Compare May 6, 2025 12:38
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from bc8d7a3 to cb19a5a Compare May 6, 2025 12:38
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from d7de69e to 44caee2 Compare May 6, 2025 14:28
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from cb19a5a to 48e6983 Compare May 6, 2025 14:28
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from 44caee2 to a8e8e7f Compare May 6, 2025 14:52
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 48e6983 to c3e64f2 Compare May 6, 2025 14:52
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from c09bfad to 0130640 Compare May 15, 2025 10:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from b3ee95f to f69f744 Compare May 15, 2025 10:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from 0130640 to 13920fd Compare May 19, 2025 22:13
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from f69f744 to eda0355 Compare May 19, 2025 22:13
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from 13920fd to d37f6c7 Compare May 25, 2025 14:56
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from eda0355 to 2555db3 Compare May 25, 2025 14:56
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from d37f6c7 to 535729d Compare May 25, 2025 15:27
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 2555db3 to 87d7e6b Compare May 25, 2025 15:28
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from 535729d to 33e4bf3 Compare May 25, 2025 17:12
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 87d7e6b to 53e128a Compare May 25, 2025 17:12
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from 33e4bf3 to 56c4333 Compare May 26, 2025 08:03
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 53e128a to 2c1e7c9 Compare May 26, 2025 08:03
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from 56c4333 to 555c614 Compare May 26, 2025 09:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 2c1e7c9 to d63a41c Compare May 26, 2025 09:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from 555c614 to 5a7574f Compare May 26, 2025 11:54
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from d63a41c to 9968c05 Compare May 26, 2025 11:54
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 26, 2025 14:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files branch from 5a7574f to e3082f2 Compare May 26, 2025 14:50
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 9968c05 to 5c4c19d Compare May 26, 2025 14:50
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hard-code_gas_costs_in_constants.cairo branch from 5c4c19d to 7440097 Compare May 27, 2025 10:29
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-01-feat_apollo_infra_utils_add_function_to_format_cairo0_source_files to main-v0.14.0 May 27, 2025 10:29
Copy link

Artifacts upload workflows:

Copy link

Benchmark movements: No major performance changes detected.

@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants