Skip to content

test(apollo_starknet_os_program): add OS constants test #6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo
Choose a base branch
from
Draft

test(apollo_starknet_os_program): add OS constants test #6274

wants to merge 1 commit into from
+224 −0

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

This was referenced May 1, 2025
Draft
Draft
Draft
Draft
Draft
Closed
Draft
Draft
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented May 1, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dorimedini-starkware dorimedini-starkware mentioned this pull request May 1, 2025
Draft
@github-actions GitHub Actions
Copy link

github-actions bot commented May 1, 2025 •
edited
Loading

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from ab2b8ce to f046919 Compare May 1, 2025 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 1b132cd to 1e3cfe3 Compare May 1, 2025 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from f046919 to 49a4272 Compare May 1, 2025 14:43
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 1e3cfe3 to 5db3b08 Compare May 1, 2025 14:43
@dorimedini-starkware dorimedini-starkware changed the title test(apollo_starknet_os_program): OS constants test test(apollo_starknet_os_program): add OS constants test May 1, 2025
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch 4 times, most recently from 122bde7 to 53ef04c Compare May 2, 2025 14:13
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 49a4272 to bd62713 Compare May 2, 2025 14:19
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 53ef04c to b367524 Compare May 2, 2025 14:19
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2025

Benchmark movements:
full_committer_flow performance regressed!
full_committer_flow time: [31.706 ms 31.926 ms 32.166 ms]
change: [+1.0052% +1.8338% +2.7775%] (p = 0.00 < 0.05)
Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from bd62713 to f584300 Compare May 5, 2025 11:00
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from b367524 to b4f3245 Compare May 5, 2025 11:01
@github-actions GitHub Actions
Copy link

github-actions bot commented May 5, 2025

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [34.962 ms 35.486 ms 36.112 ms]
change: [+1.1046% +2.4982% +4.1124%] (p = 0.00 < 0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
2 (2.00%) high mild
8 (8.00%) high severe

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from f584300 to 0ba7ba3 Compare May 5, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from b4f3245 to 682814a Compare May 5, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 0ba7ba3 to 24ca068 Compare May 5, 2025 13:10
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 682814a to 3d41b01 Compare May 5, 2025 13:10
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 24ca068 to f6cbf04 Compare May 6, 2025 12:29
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 3d41b01 to 8fbf9a5 Compare May 6, 2025 12:29
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from f6cbf04 to 49a188c Compare May 6, 2025 12:39
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 8fbf9a5 to 3c7bc0e Compare May 6, 2025 12:39
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 49a188c to 4b6984f Compare May 6, 2025 14:28
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 3c7bc0e to 6754882 Compare May 6, 2025 14:29
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2025

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.817 ms 36.398 ms 37.058 ms]
change: [+1.6533% +3.5426% +5.3684%] (p = 0.00 < 0.05)
Performance has regressed.
Found 13 outliers among 100 measurements (13.00%)
2 (2.00%) high mild
11 (11.00%) high severe

@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-feat_apollo_starknet_os_program_hex_contract_addresses_in_constants.cairo branch from 4b6984f to dbebf8f Compare May 6, 2025 14:53
@dorimedini-starkware dorimedini-starkware force-pushed the 05-01-test_apollo_starknet_os_program_os_constants_test branch from 6754882 to a8eff46 Compare May 6, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dorimedini-starkware @reviewable-StarkWare