Integrate Bitwise Builtin

[Gali-StarkWare]

This change is 

[Gali-StarkWare]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Integrate Bitwise Builtin #395 👈 (View in Graphite)
• Integrate Verify Bitwise Xor 9 #402
• Bitwise Builtin Files #381
• Verify Bitwise Xor 9 Files #401
• Add Bitwise Xor to Preprocessed Column Enum #380
• Bitwise Xor Struct #379
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ohad-starkware]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @Gali-StarkWare and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/air.rs line 70 at r1 (raw file):

    pub verify_instruction: verify_instruction::Claim,
    pub builtins: BuiltinsClaim,
    pub verify_bitwise_xor_9: verify_bitwise_xor_9::Claim,

reorder after range checks ( v > r)

---

stwo_cairo_prover/crates/prover/src/cairo_air/builtins_air.rs line 72 at r1 (raw file):

                (bitwise.stop_ptr - bitwise.begin_addr).is_power_of_two(),
                "bitwise segment length is not a power of two"
            );

try using inspect here, I don't know if it's much nicer. just something I saw while on leave.

Code quote:

        let bitwise_builtin_trace_generator = builtin_segments.bitwise.map(|bitwise| {
            assert!(
                (bitwise.stop_ptr - bitwise.begin_addr).is_power_of_two(),
                "bitwise segment length is not a power of two"
            );

---

stwo_cairo_prover/crates/prover/src/cairo_air/builtins_air.rs line 109 at r1 (raw file):

            };
        let (bitwise_builtin_claim, bitwise_builtin_interaction_gen) =
            if let Some(bitwise_builtin_trace_generator) = self.bitwise_builtin_trace_generator {

map?

[Gali-StarkWare]

Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @ohad-starkware and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/air.rs line 70 at r1 (raw file):

Previously, ohad-starkware (Ohad) wrote…

reorder after range checks ( v > r)

Done.

---

stwo_cairo_prover/crates/prover/src/cairo_air/builtins_air.rs line 72 at r1 (raw file):

Previously, ohad-starkware (Ohad) wrote…

try using inspect here, I don't know if it's much nicer. just something I saw while on leave.

Looks nice but runs on an iterator

---

stwo_cairo_prover/crates/prover/src/cairo_air/builtins_air.rs line 109 at r1 (raw file):

Previously, ohad-starkware (Ohad) wrote…

map?

I need a tuple of options here so it doesn't work

[ohad-starkware]

Reviewed 1 of 2 files at r5.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare and @shaharsamocha7)

---

stwo_cairo_prover/crates/prover/src/cairo_air/builtins_air.rs line 109 at r1 (raw file):

Previously, Gali-StarkWare wrote…

I need a tuple of options here so it doesn't work

you can have this return an option of a tuple and then do the map from outside