Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Verify Bitwise Xor 9 #402

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Gali-StarkWare
Copy link
Contributor

@Gali-StarkWare Gali-StarkWare commented Jan 28, 2025

This change is Reviewable

Copy link
Contributor Author

Gali-StarkWare commented Jan 28, 2025

@Gali-StarkWare Gali-StarkWare self-assigned this Jan 28, 2025
@Gali-StarkWare Gali-StarkWare marked this pull request as ready for review January 28, 2025 15:51
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from bcde69c to 227eca8 Compare January 28, 2025 15:55
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @Gali-StarkWare and @shaharsamocha7)


stwo_cairo_prover/crates/prover/src/cairo_air/air.rs line 70 at r1 (raw file):

    pub verify_instruction: verify_instruction::Claim,
    pub builtins: BuiltinsClaim,
    pub verify_bitwise_xor_9: verify_bitwise_xor_9::Claim,

why is the ordering like that?

@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from 227eca8 to c2b33a6 Compare January 29, 2025 13:17
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from c2b33a6 to bc21129 Compare January 30, 2025 09:11
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from bc21129 to b2bb977 Compare January 30, 2025 09:14
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from b2bb977 to 145ac49 Compare January 30, 2025 09:30
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from 145ac49 to c160ccd Compare January 30, 2025 09:34
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch 2 times, most recently from bf099e0 to a54c5c6 Compare January 30, 2025 09:49
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from a54c5c6 to f8c125f Compare January 30, 2025 11:42
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from f8c125f to 7fcc84c Compare January 30, 2025 12:11
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch 2 times, most recently from 8679c4f to 4da0272 Compare February 2, 2025 14:51
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch 2 times, most recently from a9eba5d to 97dcc67 Compare February 3, 2025 11:02
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from 97dcc67 to 297edb8 Compare February 3, 2025 11:29
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from 297edb8 to 1456573 Compare February 3, 2025 11:39
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from 1456573 to c56ad9c Compare February 3, 2025 12:48
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from c56ad9c to 534dd47 Compare February 3, 2025 14:01
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch 2 times, most recently from da07ab5 to 22b7de0 Compare February 3, 2025 15:06
Copy link
Contributor

@ohad-starkware ohad-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@Gali-StarkWare Gali-StarkWare force-pushed the gali/bitwise branch 2 times, most recently from 12ad7d1 to dbc528c Compare February 3, 2025 15:50
@Gali-StarkWare Gali-StarkWare changed the base branch from gali/bitwise to graphite-base/402 February 3, 2025 17:21
@Gali-StarkWare Gali-StarkWare force-pushed the gali/integrate_verify_bitwise_xor branch from 22b7de0 to 79c1ca3 Compare February 3, 2025 17:25
@Gali-StarkWare Gali-StarkWare changed the base branch from graphite-base/402 to main February 3, 2025 17:25
@Gali-StarkWare Gali-StarkWare mentioned this pull request Feb 3, 2025
Copy link
Contributor Author

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)

@Gali-StarkWare Gali-StarkWare merged commit c5b32a5 into main Feb 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants