Refactor cmd/timoni and extract reconciler logic to dedicated package
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
changed the title
errors.Decribe and runtimebuild.BuildFiles from cmd/timonicmd/timoni
errordeveloper
force-pushed
the
cmd-timoni-refactor
branch
4 times, most recently
from
987f974
to
ffa58de
Compare
errordeveloper
force-pushed
the
cmd-timoni-refactor
branch
2 times, most recently
from
b191e4c
to
16617a1
Compare
errordeveloper
force-pushed
the
cmd-timoni-refactor
branch
3 times, most recently
from
de904bc
to
0b9f5d7
Compare
|
@stefanprodan I've rebased and made it green, there is still some work, but maybe woth a quick review whenever you have a chance? |
errordeveloper
force-pushed
the
cmd-timoni-refactor
branch
15 times, most recently
from
d4e85da
to
8e2703d
Compare
errordeveloper
force-pushed
the
cmd-timoni-refactor
branch
from
8e2703d
to
ecc8139
Compare
|
@errordeveloper looks great so far. Will you be adding deletion to the reconciler package? |
|
I can add deletion methods in this PR or leave for another one, what would you prefer? |
stefanprodan
added
enhancement
I would leave it for another PR, this has lots of good things already, thank you! |
stefanprodan
changed the title
cmd/timonicmd/timoni and extract reconciler logic to dedicated package
Ok, I have cleaned up most of the commits, just the last two need some attention. I can resolve sometime soon, but feel free to do it if you would like to merge. |
errordeveloper
force-pushed
the
cmd-timoni-refactor
branch
from
ecc8139
to
ab21055
Compare
Signed-off-by: Ilya Dmitrichenko <[email protected]>
Signed-off-by: Ilya Dmitrichenko <[email protected]>
Signed-off-by: Ilya Dmitrichenko <[email protected]>
Signed-off-by: Ilya Dmitrichenko <[email protected]>
errordeveloper
force-pushed
the
cmd-timoni-refactor
branch
from
ab21055
to
330e28f
Compare
all done now! |
Signed-off-by: Ilya Dmitrichenko <[email protected]>
Signed-off-by: Ilya Dmitrichenko <[email protected]>
Provide an interactive and non-interactive version that have different logging, ensure reasonanble level of reuse within each implementation Signed-off-by: Ilya Dmitrichenko <[email protected]>
- rename `apply.InstanceApplier` to `reconciler.Reconciler` - use separate files inside the package - move interactive functions to dedicated `reconciler.InteractiveReconciler` type Signed-off-by: Ilya Dmitrichenko <[email protected]>
It turns out that a bare function is not treated the same way as a struct when it comes to matching it to an interface Signed-off-by: Ilya Dmitrichenko <[email protected]>
Signed-off-by: Ilya Dmitrichenko <[email protected]>
errordeveloper
force-pushed
the
cmd-timoni-refactor
branch
from
330e28f
to
b8686f0
Compare
|
@stefanprodan should be good to merge now! |
stefanprodan
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: #10