Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor cmd/timoni and extract reconciler logic to dedicated package #366

Merged
merged 10 commits into from
Jun 11, 2024
Merged

Refactor cmd/timoni and extract reconciler logic to dedicated package #366

merged 10 commits into from
Jun 11, 2024

Commits on Jun 10, 2024

  1. Factor out applyInstance function from apply_bundle.go (WIP) 

    Signed-off-by: Ilya Dmitrichenko <[email protected]>
    @errordeveloper
    errordeveloper committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    677a996 View commit details
    Browse the repository at this point in the history

  2. Adapt applyInstance function to suite apply.go (WIP) 

    Signed-off-by: Ilya Dmitrichenko <[email protected]>
    @errordeveloper
    errordeveloper committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    dcbf2f7 View commit details
    Browse the repository at this point in the history

  3. Get rid of global state from applyInstance (WIP) 

    Signed-off-by: Ilya Dmitrichenko <[email protected]>
    @errordeveloper
    errordeveloper committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    d33ffb6 View commit details
    Browse the repository at this point in the history

  4. Correct isStandaloneInstance logic 

    Signed-off-by: Ilya Dmitrichenko <[email protected]>
    @errordeveloper
    errordeveloper committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a7181f5 View commit details
    Browse the repository at this point in the history

  5. Create internal/{apply,dyff,log} (WIP) 

    Signed-off-by: Ilya Dmitrichenko <[email protected]>
    @errordeveloper
    errordeveloper committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    0ff53bc View commit details
    Browse the repository at this point in the history

  6. Undo moving of some logger function reliant on shared state 

    Signed-off-by: Ilya Dmitrichenko <[email protected]>
    @errordeveloper
    errordeveloper committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    e6526f7 View commit details
    Browse the repository at this point in the history

  7. Split up applier logic into multiple functions 

    Provide an interactive and non-interactive version that have different
logging, ensure reasonanble level of reuse within each implementation

Signed-off-by: Ilya Dmitrichenko <[email protected]>
    @errordeveloper
    errordeveloper committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    90a26a3 View commit details
    Browse the repository at this point in the history

  8. Naming improvements 

    - rename `apply.InstanceApplier` to `reconciler.Reconciler`
- use separate files inside the package
- move interactive functions to dedicated `reconciler.InteractiveReconciler` type

Signed-off-by: Ilya Dmitrichenko <[email protected]>
    @errordeveloper
    errordeveloper committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    3448c57 View commit details
    Browse the repository at this point in the history

  9. Simplify inteface definition to work with a bare function 

    It turns out that a bare function is not treated the same way as
a struct when it comes to matching it to an interface

Signed-off-by: Ilya Dmitrichenko <[email protected]>
    @errordeveloper
    errordeveloper committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    1564099 View commit details
    Browse the repository at this point in the history

  10. Refine ownership conflict error messages and fix associated tests 

    Signed-off-by: Ilya Dmitrichenko <[email protected]>
    @errordeveloper
    errordeveloper committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    b8686f0 View commit details
    Browse the repository at this point in the history