This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
UI: Fix z-index in modal elements #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yannbf This PR looks good to me. It should work for both 7.0 and 8.0. |
yannbf
reviewed
Dec 20, 2023
| @@ -100,7 +100,7 @@ export function GuidedTour({ | |||
| }, | |||
| }, | |||
| { | |||
| target: "#root div[role=main]", | |||
| target: "#root > div", | |||
There was a problem hiding this comment.
This does not work for Storybook 7 and 8. The elements structure changed and there's no role=main anymore. This needs to be tweaked and tested in both Storybook 7 and 8 (via a canary release)
This reverts commit 623d2b2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
1.0.11-canary.78.9bdace7.0✨ Test out this PR locally via: