-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DE-2698] Update/remove any of #1
Conversation
Is there somewhere we can document this, even just a code comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the update is in JSON we can't really leave comments in line, but let's make a comment about it in the README? can't think of a different spot that makes more sense
@@ -1,6 +1,6 @@ | |||
[tool.poetry] | |||
name = "tap-anvil" | |||
version = "0.1.5" | |||
version = "0.1.6" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this is the only place that need to update? is there any other actions needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's it, we're installing from main AFAIK anyway, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do have a version number here
https://github.com/svinstech/vouch-airflow/blob/main/setup.sh#L26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah so we do need to update in airflow too and create the tag/release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah!
seems like anyOf type is skipped by target-snowflake and it's a known issue here. i forked our tap-anvil and updated the schema, ran it locally and got createdAt/updatedAt in
maybe we just make it string in
raw
and parse it later instg