bootstrap: fix regression #8285
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkhouri
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
xedin,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand and
owenv
as code owners
|
One thing I notice is that a lot of CMake and ninja output was still dumped out after your logging changes from December, but only SwiftPM build output was silenced, so a simpler way to fix this might be to look into how the two invocations differ. This definitely fixes the SwiftPM build output regression, but if you find a simpler way to do it, that's fine with me too. |
bkhouri
force-pushed
the
t/main/gh8231_bootstrap_does_not_output_to_console_in_ci
branch
from
a337501 to
dc634cc
Compare
The `Utilities/bootstrap` script is no longer emitting Swift PM build status information. This change reverted the swiftlang#8161 and then converted the print calls to use python's logging module. Fixes swiftlang#8281
bkhouri
force-pushed
the
t/main/gh8231_bootstrap_does_not_output_to_console_in_ci
branch
from
dc634cc to
f120d02
Compare
|
@swift-ci please test |
|
@swift-ci please test windows |
bkhouri
added
continuous integration/deployment
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Utilities/bootstrapscript is no longer emitting Swift PM build status information.This change reverted the #8161 and then converted the print calls to use python's logging module.
Fixes #8281