Switch to golangci-lint GH action #2493
Conversation
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/S
afrittoli
force-pushed
the
golangci-lint-action
branch
from
bd4125a to
524e3f5
Compare
afrittoli
force-pushed
the
golangci-lint-action
branch
2 times, most recently
from
bb2ad80 to
796261d
Compare
tekton-robot
added
size/M
Start using the golangci-lint github action and stop using the check as part of the build jobs. This way the version of the actions can be maintained by dependabot, the version of golangci-lint can be updated in the YAML and code in PRs can be annotated with issues. It also reduces the load in the prow job slighlty, saving a little infra cost. Removing the failing golang lint surfaced some issues in the yamllint. Issues in workflow YAMLs have been fixed. All testdata YAML files have been excluded from linting. Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
force-pushed
the
golangci-lint-action
branch
from
796261d to
1711092
Compare
|
@vdemeester @PuneetPunamiya @jkhelil this is ready for review now. It would be great to merge it soon-ish to unlock CI |
|
@afrittoli Great work, Thank you for unblocking Ci with this |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/cherry-pick release-v0.73.x |
|
@jkhelil: new pull request created: #2501 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-v0.74.x |
|
@jkhelil: new pull request created: #2506 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-v0.74.x |
|
@jkhelil: new pull request created: #2508 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
Start using the golangci-lint github action and stop using the check as part of the build jobs.
This way the version of the actions can be maintained by dependabot, the version of golangci-lint can be updated in the YAML and code in PRs can be annotated with issues. It also reduces the load in the prow job slighlty, saving a little infra cost.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes