Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip match label values for certain matchers #8084

Merged
merged 1 commit into from
Feb 2, 2025
Merged

skip match label values for certain matchers #8084

merged 1 commit into from
Feb 2, 2025

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jan 31, 2025 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

For certain types of matchers we can skip matching values when the value is empty.

Verification

@yeya24 yeya24 marked this pull request as ready for review January 31, 2025 22:00
@yeya24 yeya24 merged commit 45013e1 into thanos-io:main Feb 2, 2025
20 of 22 checks passed
@yeya24 yeya24 deleted the skip-matching-values branch February 2, 2025 18:30
@yeya24 yeya24 mentioned this pull request Feb 3, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saswatamcode saswatamcode saswatamcode approved these changes

@harry671003 harry671003 Awaiting requested review from harry671003

@GiedriusS GiedriusS Awaiting requested review from GiedriusS

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeya24 @saswatamcode