Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip match label values for certain matchers #8084

Merged
merged 1 commit into from
Feb 2, 2025
Merged

skip match label values for certain matchers #8084

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/store/bucket.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2978,6 +2978,12 @@ func toPostingGroup(ctx context.Context, lvalsFn func(name string) ([]string, er
return nil, nil, err
}

// If the matcher is ="" or =~"", it is the same as removing all values for the label.
// We can skip calling `Matches` here.
if m.Value == "" && (m.Type == labels.MatchEqual || m.Type == labels.MatchRegexp) {
return newPostingGroup(true, m.Name, nil, vals), vals, nil
}

for i, val := range vals {
if (i+1)%checkContextEveryNIterations == 0 && ctx.Err() != nil {
return nil, nil, ctx.Err()
Expand Down Expand Up @@ -3006,6 +3012,12 @@ func toPostingGroup(ctx context.Context, lvalsFn func(name string) ([]string, er
return nil, nil, err
}

// If the matcher is !="" or !~"", it is the same as adding all values for the label.
// We can skip calling `Matches` here.
if m.Value == "" && (m.Type == labels.MatchNotEqual || m.Type == labels.MatchNotRegexp) {
return newPostingGroup(false, m.Name, vals, nil), vals, nil
}

var toAdd []string
for i, val := range vals {
if (i+1)%checkContextEveryNIterations == 0 && ctx.Err() != nil {
Expand Down
Loading