React 18 compatibility #3424
Open
React 18 compatibility #3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…events-calendar/event-tickets into fix/TEC-5322-wp-67-packages
…events-calendar/event-tickets into fix/TEC-5322-wp-67-packages
…events-calendar/event-tickets into fix/TEC-5322-wp-67-packages
…events-calendar/event-tickets into fix/TEC-5322-wp-67-packages
The intent behind the original filtering seemed to be to remove the tickets from the post/event when the Ticket item is removed. This is not what is currently happening, so this code seems to not fulfill its intent, and it's generating a fatal on the first click of the "Add a Ticket" button in the Tickets (plural) block.
While the properties were marked as required, the element will render and behave correctly when rendering in the context of a new post and a new tickets block with those properties undefined. This change normalizes the current state of things.
another instance where the component will render and behave just fine in the context of a new post and a new Tickets block, this change normalized the current behaviour removing a warning from the console
…events-calendar/event-tickets into fix/TEC-5322-wp-67-packages
The update is not required and not significant and would require updating `slic`.
…events-calendar/event-tickets into fix/TEC-5322-wp-67-packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.