-
Notifications
You must be signed in to change notification settings - Fork 559
Deprecate modular contracts from Explore #7515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Deprecate modular contracts from Explore #7515
Conversation
Co-authored-by: jake <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe updates deprecate the "Pre-built Modular" contracts from the Explore UI and documentation. The relevant category is hidden in the dashboard, deprecation warnings are added to related documentation pages, sidebar navigation links to modular contracts are commented out with deprecation notes, and redirects for deprecated modular contract URLs are added. No functional or control flow changes are introduced. Changes
Sequence Diagram(s)No sequence diagram is generated as the changes are limited to configuration, documentation, UI visibility, and redirects without affecting control flow or feature logic. Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (8)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7515 +/- ##
=======================================
Coverage 51.96% 51.96%
=======================================
Files 952 952
Lines 64224 64224
Branches 4237 4237
=======================================
Hits 33377 33377
Misses 30740 30740
Partials 107 107
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Co-authored-by: jake <[email protected]>
], | ||
name: "Pre-built Modular", | ||
}, | ||
// DEPRECATED: Pre-built Modular contracts have been deprecated from explore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete instead of commenting it out, we have git history if we need it back later
href: `${buildSlug}/modular-contracts`, | ||
name: "Modular Contracts", | ||
}, | ||
// DEPRECATED: Modular contracts deprecated from build section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
// DEPRECATED: Pre-built modular contracts redirects | ||
"/contracts/explore/pre-built-modular/token": "/contracts/explore/overview", | ||
"/contracts/explore/pre-built-modular/token-drop": | ||
"/contracts/explore/overview", | ||
"/contracts/explore/pre-built-modular/nft-collection": | ||
"/contracts/explore/overview", | ||
"/contracts/explore/pre-built-modular/nft-drop": | ||
"/contracts/explore/overview", | ||
"/contracts/explore/pre-built-modular/open-edition": | ||
"/contracts/explore/overview", | ||
"/contracts/explore/pre-built-modular/edition": "/contracts/explore/overview", | ||
"/contracts/explore/pre-built-modular/edition-drop": | ||
"/contracts/explore/overview", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we instead redirect into the appropriate token/asset
flow?
PR-Codex overview
This PR focuses on deprecating the
modular-contracts
and related pre-built modular contracts from the Explore section, while keeping documentation available for existing users. It also updates the sidebar and redirects accordingly.Detailed summary
modular-contracts
indata.ts
.CATEGORIES
to keepMODULAR_CONTRACTS
but mark it as deprecated.modular Token
andNFT Collection
contracts.Summary by CodeRabbit
Bug Fixes
Documentation