Skip to content

Deprecate modular contracts from Explore #7515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/dashboard/src/app/(app)/(dashboard)/explore/data.ts
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,8 @@ const MODULAR_CONTRACTS = {
displayName: "Modular Contracts",
id: "modular-contracts",
name: "modular",
// DEPRECATED: Modular contracts are no longer shown in explore
showInExplore: false,
} satisfies ExploreCategory;

const SUPERCHAIN = {
Expand Down Expand Up @@ -315,6 +317,7 @@ const SMART_WALLET = {

const CATEGORIES: Record<string, ExploreCategory> = {
[POPULAR.id]: POPULAR,
// Keep MODULAR_CONTRACTS available for existing users but deprecated from explore
[MODULAR_CONTRACTS.id]: MODULAR_CONTRACTS,
[SUPERCHAIN.id]: SUPERCHAIN,
[NFTS.id]: NFTS,
Expand Down
13 changes: 13 additions & 0 deletions apps/portal/redirects.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -747,6 +747,19 @@ const contractRedirects = {
"/contracts/DropERC721": "/contracts/explore/pre-built-contracts/nft-drop",
"/contracts/DropERC1155":
"/contracts/explore/pre-built-contracts/edition-drop",
// DEPRECATED: Pre-built modular contracts redirects
"/contracts/explore/pre-built-modular/token": "/contracts/explore/overview",
"/contracts/explore/pre-built-modular/token-drop":
"/contracts/explore/overview",
"/contracts/explore/pre-built-modular/nft-collection":
"/contracts/explore/overview",
"/contracts/explore/pre-built-modular/nft-drop":
"/contracts/explore/overview",
"/contracts/explore/pre-built-modular/open-edition":
"/contracts/explore/overview",
"/contracts/explore/pre-built-modular/edition": "/contracts/explore/overview",
"/contracts/explore/pre-built-modular/edition-drop":
"/contracts/explore/overview",
Comment on lines +750 to +762
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we instead redirect into the appropriate token/asset flow?

//design documentation
"/contracts/design/Drop": "/contracts/design-docs/drop",
"/contracts/design/Marketplace": "/contracts/design-docs/marketplace",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ import collectionMintable from '../assets/erc721_mintable.png'

# Deploy a modular NFT Collection contract

<Callout variant="warning" title="Deprecated">
Pre-built modular contracts have been deprecated from the Explore section. While this documentation remains available for existing users, we recommend using [standard NFT collection contracts](/contracts/explore/pre-built-contracts/nft-collection) for new deployments.
</Callout>

The NFT Collection contract creates a unique collection of NFTs based on the ERC-721A standard. NFTs are minted to the creator’s wallet as they are added to the collection. NFTs are still transferable, able to be sold on a marketplace, and perform any other actions as defined by ERC-721A.

For advanced use-cases requiring , NFT Collection includes signature-based minting capabilities.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ import tokenTransferable from '../assets/erc20_transferable.png'

# Deploy a modular Token Contract

<Callout variant="warning" title="Deprecated">
Pre-built modular contracts have been deprecated from the Explore section. While this documentation remains available for existing users, we recommend using [standard token contracts](/contracts/explore/pre-built-contracts/token) for new deployments.
</Callout>

The modular Token contract creates digital currencies and is compliant with the ERC-20 standard. This contract defines a common set of
rules for tokens including how they can be transferred, how transactions are approved, and how data about token balances is accessed.

Expand Down
108 changes: 55 additions & 53 deletions apps/portal/src/app/contracts/sidebar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -56,54 +56,56 @@ export const sidebar: SideBar = {
href: "/contracts/explore/overview",
name: "Overview",
},
{
links: [
{
links: [
{
href: `${prebuiltModular}/token`,
name: "Token",
},
{
href: `${prebuiltModular}/token-drop`,
name: "Token Drop",
},
],
name: "ERC-20",
},
{
links: [
{
href: `${prebuiltModular}/nft-collection`,
name: "NFT Collection",
},
{
href: `${prebuiltModular}/nft-drop`,
name: "NFT Drop",
},
{
href: `${prebuiltModular}/open-edition`,
name: "Open Edition",
},
],
name: "ERC-721",
},
{
links: [
{
href: `${prebuiltModular}/edition`,
name: "Edition",
},
{
href: `${prebuiltModular}/edition-drop`,
name: "Edition Drop",
},
],
name: "ERC-1155",
},
],
name: "Pre-built Modular",
},
// DEPRECATED: Pre-built Modular contracts have been deprecated from explore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete instead of commenting it out, we have git history if we need it back later

// Keeping framework documentation available but removing pre-built contract references
// {
// links: [
// {
// links: [
// {
// href: `${prebuiltModular}/token`,
// name: "Token",
// },
// {
// href: `${prebuiltModular}/token-drop`,
// name: "Token Drop",
// },
// ],
// name: "ERC-20",
// },
// {
// links: [
// {
// href: `${prebuiltModular}/nft-collection`,
// name: "NFT Collection",
// },
// {
// href: `${prebuiltModular}/nft-drop`,
// name: "NFT Drop",
// },
// {
// href: `${prebuiltModular}/open-edition`,
// name: "Open Edition",
// },
// ],
// name: "ERC-721",
// },
// {
// links: [
// {
// href: `${prebuiltModular}/edition`,
// name: "Edition",
// },
// {
// href: `${prebuiltModular}/edition-drop`,
// name: "Edition Drop",
// },
// ],
// name: "ERC-1155",
// },
// ],
// name: "Pre-built Modular",
// },
{
links: [
{
Expand Down Expand Up @@ -448,11 +450,11 @@ export const sidebar: SideBar = {
href: `${buildSlug}/get-started`,
name: "Get Started",
},
// modular contracts
{
href: `${buildSlug}/modular-contracts`,
name: "Modular Contracts",
},
// DEPRECATED: Modular contracts deprecated from build section
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

// {
// href: `${buildSlug}/modular-contracts`,
// name: "Modular Contracts",
// },
// base contracts
{
href: `${baseContractsSlug}`,
Expand Down
Loading