Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md (update EnvFactoryRegistered params) #1228

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

konnovdev
Copy link
Contributor

To initiate a EnvFactoryRegistered, we now need train_seed=0 and test_seed=0 arguments passed instead of seed previously written in documentation code snippet.

  • I have added the correct label(s) to this Pull Request or linked the relevant issue(s)
  • I have provided a description of the changes in this Pull Request
  • I have added documentation for my changes and have listed relevant changes in CHANGELOG.md
  • If applicable, I have added tests to cover my changes.
  • I have reformatted the code using poe format
  • I have checked style and types with poe lint and poe type-check
  • (Optional) I ran tests locally with poe test
    (or a subset of them with poe test-reduced) ,and they pass
  • (Optional) I have tested that documentation builds correctly with poe doc-build

Change params in EnvFactoryRegistered() constructor
@Trinkle23897 Trinkle23897 merged commit 2463f8b into thu-ml:master Dec 9, 2024
4 checks passed
@konnovdev konnovdev deleted the patch-1 branch December 10, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants