Defer coroization #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents accidentally statically importing code from coro, which could cause problems if coro is then upgraded to a newer version than elmer was built with
hadley
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't perform
coro::generator/coro::async_generatortransformation at package build time; if we do so, we're basically hardcoding the coro transformation into that built package, which might be a problem if coro is then upgraded.We take two approaches to this:
rlang::on_loadto defer their definition until package.onLoad.generator_method/async_generator_methoddecorators and make them even more complicated, by having them defer the coro transformation until the first time they are invoked.