Skip to content

Topcoder admin app: move src/apps/gamification-admin -> src/apps/admin #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feat/system-admin
Choose a base branch
from

Conversation

suppermancool
Copy link
Collaborator

(cherry picked from commit 2f1995b)

Topcoder admin app: move src/apps/gamification-admin -> src/apps/admin

@@ -1,4 +1,4 @@
import { baseDetailPath, createBadgePath } from '~/apps/gamification-admin'
import { baseDetailPath, createBadgePath } from '~/apps/admin/src/platform/gamification-admin'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path ~/apps/admin/src/platform/gamification-admin is correct and that the files exist at this location. Double-check for any potential issues with module resolution that might arise from this change.

@@ -120,13 +120,13 @@ const SkillManagementLandingPage: LazyLoadedComponent = lazyLoad(
'LandingPage',
)
const BadgeDetailPage: LazyLoadedComponent = lazyLoad(
() => import('../../gamification-admin/src/pages/badge-detail/BadgeDetailPage'),
() => import('./platform/gamification-admin/src/pages/badge-detail/BadgeDetailPage'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to './platform/gamification-admin/src/pages/badge-detail/BadgeDetailPage'. Ensure that this new path is correct and that the file exists at the specified location.

)
const BadgeListingPage: LazyLoadedComponent = lazyLoad(
() => import('../../gamification-admin/src/pages/badge-listing/BadgeListingPage'),
() => import('./platform/gamification-admin/src/pages/badge-listing/BadgeListingPage'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to './platform/gamification-admin/src/pages/badge-listing/BadgeListingPage'. Verify that this path is correct and the file is located at this new path.

)
const CreateBadgePage: LazyLoadedComponent = lazyLoad(
() => import('../../gamification-admin/src/pages/create-badge/CreateBadgePage'),
() => import('./platform/gamification-admin/src/pages/create-badge/CreateBadgePage'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been changed to './platform/gamification-admin/src/pages/create-badge/CreateBadgePage'. Confirm that this path is accurate and the file exists at this location.

@@ -5,7 +5,7 @@ import { Dispatch, FC, SetStateAction, useMemo } from 'react'
import { Link } from 'react-router-dom'
import classNames from 'classnames'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort has been updated. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the Sort module is accessible from this location. Verify that the module has been moved or is correctly linked in the new directory structure.

@@ -5,7 +5,7 @@ import { Dispatch, FC, SetStateAction, useMemo } from 'react'
import { Link } from 'react-router-dom'
import classNames from 'classnames'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the Sort module is accessible from this location.

@@ -4,7 +4,7 @@ import { useNavigate } from 'react-router-dom'
import { EnvironmentConfig } from '~/config'
import { useWindowSize, WindowSize } from '~/libs/shared'
import { Button, colWidthType, LinkButton, Table, type TableColumn } from '~/libs/ui'
import { Sort } from '~/apps/gamification-admin/src/game-lib/pagination'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to ~/apps/admin/src/platform/gamification-admin/src/game-lib, which seems unnecessarily long and potentially confusing. Consider simplifying the directory structure if possible to make the import paths more intuitive.

@@ -10,7 +10,7 @@ import {
Table,
type TableColumn,
} from '~/libs/ui'
import { Sort } from '~/apps/gamification-admin/src/game-lib/pagination'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the Sort module is accessible from this location.

@@ -7,7 +7,7 @@ import {
useReducer,
} from 'react'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort seems unnecessarily long and redundant. Consider simplifying the path if possible, for example by restructuring the directories or using aliasing to make the import more concise.

@@ -7,7 +7,7 @@ import {
useReducer,
} from 'react'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort seems unnecessarily long and complex. Consider simplifying the directory structure or using an alias to make the import path more readable.

@@ -10,7 +10,7 @@ import {
useState,
} from 'react'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to ~/apps/admin/src/platform/gamification-admin/src/game-lib. Ensure that this new path is correct and that the Sort module is accessible from this location. If the path is incorrect, it may lead to module resolution errors.

@@ -4,7 +4,7 @@
import { Dispatch, SetStateAction, useEffect, useMemo, useState } from 'react'
import _ from 'lodash'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been changed from ~/apps/gamification-admin/src/game-lib to ~/apps/admin/src/platform/gamification-admin/src/game-lib. Ensure that the new path is correct and that the Sort module is accessible from this location. If the module has been moved, verify that all related imports are updated accordingly.

@@ -1,4 +1,4 @@
import { GameBadge } from '~/apps/gamification-admin/src/game-lib'
import { GameBadge } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path is correct and that the game-lib module is accessible from the updated location.

@@ -17,7 +17,7 @@ import {
LoadingSpinner,
PageTitle,
} from '~/libs/ui'
import { Sort } from '~/apps/gamification-admin/src/game-lib/pagination'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path is correct and that the Sort module is accessible from ~/apps/admin/src/platform/gamification-admin/src/game-lib. If there are any issues with module resolution, consider updating the project configuration or verifying the directory structure.

@@ -11,7 +11,7 @@ import {
import { sortBy } from 'lodash'

import { LoadingSpinner, PageTitle } from '~/libs/ui'
import { Sort } from '~/apps/gamification-admin/src/game-lib/pagination'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort has been updated. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the Sort module is available at this location. If the module has been moved or renamed, update the path accordingly.

@@ -2,7 +2,10 @@
import React, { ChangeEvent } from 'react'

import { Button, IconOutline, InputSelect, InputText } from '~/libs/ui'
import { InputHandleAutocomplete, MembersAutocompeteResult } from '~/apps/gamification-admin/src/game-lib'
import {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the necessary files are present in the new location.

@@ -2,7 +2,7 @@
import React, { ChangeEvent } from 'react'

import { Button, InputSelect, InputText } from '~/libs/ui'
import { InputHandleAutocomplete, MembersAutocompeteResult } from '~/apps/gamification-admin/src/game-lib'
import { InputHandleAutocomplete, MembersAutocompeteResult } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the files are accessible from this location. If the path is incorrect, it may lead to module resolution errors.

@@ -2,10 +2,10 @@ import { Dispatch, SetStateAction, useEffect, useMemo, useRef, useState } from '
import _ from 'lodash'
import classNames from 'classnames'

import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort has been updated. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the Sort module is available at this location.

@@ -1,7 +1,8 @@
import { FC, SVGProps } from 'react'
import classNames from 'classnames'

import { Sort } from '../../../../../../apps/gamification-admin/src/game-lib/pagination'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort seems unnecessarily long and complex. Consider simplifying the directory structure or using an alias for better readability and maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant