Skip to content

Topcoder admin app: move src/apps/gamification-admin -> src/apps/admin #1126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feat/system-admin
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/apps/admin/src/admin-app.routes.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { baseDetailPath, createBadgePath } from '~/apps/gamification-admin'
import { baseDetailPath, createBadgePath } from '~/apps/admin/src/platform/gamification-admin'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path ~/apps/admin/src/platform/gamification-admin is correct and that the files exist at this location. Double-check for any potential issues with module resolution that might arise from this change.

import { AppSubdomain, ToolTitle } from '~/config'
import {
lazyLoad,
Expand Down Expand Up @@ -120,13 +120,13 @@ const SkillManagementLandingPage: LazyLoadedComponent = lazyLoad(
'LandingPage',
)
const BadgeDetailPage: LazyLoadedComponent = lazyLoad(
() => import('../../gamification-admin/src/pages/badge-detail/BadgeDetailPage'),
() => import('./platform/gamification-admin/src/pages/badge-detail/BadgeDetailPage'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to './platform/gamification-admin/src/pages/badge-detail/BadgeDetailPage'. Ensure that this new path is correct and that the file exists at the specified location.

)
const BadgeListingPage: LazyLoadedComponent = lazyLoad(
() => import('../../gamification-admin/src/pages/badge-listing/BadgeListingPage'),
() => import('./platform/gamification-admin/src/pages/badge-listing/BadgeListingPage'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to './platform/gamification-admin/src/pages/badge-listing/BadgeListingPage'. Verify that this path is correct and the file is located at this new path.

)
const CreateBadgePage: LazyLoadedComponent = lazyLoad(
() => import('../../gamification-admin/src/pages/create-badge/CreateBadgePage'),
() => import('./platform/gamification-admin/src/pages/create-badge/CreateBadgePage'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been changed to './platform/gamification-admin/src/pages/create-badge/CreateBadgePage'. Confirm that this path is accurate and the file exists at this location.

)

export const toolTitle: string = ToolTitle.admin
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Dispatch, FC, SetStateAction, useMemo } from 'react'
import { Link } from 'react-router-dom'
import classNames from 'classnames'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort has been updated. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the Sort module is accessible from this location. Verify that the module has been moved or is correctly linked in the new directory structure.

import { colWidthType, LinkButton, Table, TableColumn } from '~/libs/ui'
import { useWindowSize, WindowSize } from '~/libs/shared'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Dispatch, FC, SetStateAction, useMemo } from 'react'
import { Link } from 'react-router-dom'
import classNames from 'classnames'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the Sort module is accessible from this location.

import { useWindowSize, WindowSize } from '~/libs/shared'
import { colWidthType, Table, TableColumn } from '~/libs/ui'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useNavigate } from 'react-router-dom'
import { EnvironmentConfig } from '~/config'
import { useWindowSize, WindowSize } from '~/libs/shared'
import { Button, colWidthType, LinkButton, Table, type TableColumn } from '~/libs/ui'
import { Sort } from '~/apps/gamification-admin/src/game-lib/pagination'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to ~/apps/admin/src/platform/gamification-admin/src/game-lib, which seems unnecessarily long and potentially confusing. Consider simplifying the directory structure if possible to make the import paths more intuitive.


import { Pagination } from '../common/Pagination'
import { useEventCallback } from '../../hooks'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
Table,
type TableColumn,
} from '~/libs/ui'
import { Sort } from '~/apps/gamification-admin/src/game-lib/pagination'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the Sort module is accessible from this location.


import { Reviewer } from '../../models'
import { useEventCallback } from '../../hooks'
Expand Down
2 changes: 1 addition & 1 deletion src/apps/admin/src/lib/hooks/useManageBillingAccounts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
useReducer,
} from 'react'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort seems unnecessarily long and redundant. Consider simplifying the path if possible, for example by restructuring the directories or using aliasing to make the import more concise.


import { TABLE_PAGINATION_ITEM_PER_PAGE } from '../../config/index.config'
import { BillingAccount, FormBillingAccountsFilter } from '../models'
Expand Down
2 changes: 1 addition & 1 deletion src/apps/admin/src/lib/hooks/useManageClients.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
useReducer,
} from 'react'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort seems unnecessarily long and complex. Consider simplifying the directory structure or using an alias to make the import path more readable.


import { TABLE_PAGINATION_ITEM_PER_PAGE } from '../../config/index.config'
import { ClientInfo, FormClientsFilter } from '../models'
Expand Down
2 changes: 1 addition & 1 deletion src/apps/admin/src/lib/hooks/useTableFilterBackend.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {
useState,
} from 'react'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to ~/apps/admin/src/platform/gamification-admin/src/game-lib. Ensure that this new path is correct and that the Sort module is accessible from this location. If the path is incorrect, it may lead to module resolution errors.


export interface useTableFilterBackendProps<T> {
page: number
Expand Down
2 changes: 1 addition & 1 deletion src/apps/admin/src/lib/hooks/useTableFilterLocal.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import { Dispatch, SetStateAction, useEffect, useMemo, useState } from 'react'
import _ from 'lodash'

import { Sort } from '~/apps/gamification-admin/src/game-lib'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been changed from ~/apps/gamification-admin/src/game-lib to ~/apps/admin/src/platform/gamification-admin/src/game-lib. Ensure that the new path is correct and that the Sort module is accessible from this location. If the module has been moved, verify that all related imports are updated accordingly.


import { TABLE_PAGINATION_ITEM_PER_PAGE } from '../../config/index.config'
import { checkIsDateObject, checkIsNumberObject, checkIsStringNumeric } from '../utils'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { GameBadge } from '~/apps/gamification-admin/src/game-lib'
import { GameBadge } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path is correct and that the game-lib module is accessible from the updated location.


import { CreateBadgeRequest, createBadgeSubmitRequestAsync } from './create-badge-store'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
LoadingSpinner,
PageTitle,
} from '~/libs/ui'
import { Sort } from '~/apps/gamification-admin/src/game-lib/pagination'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path is correct and that the Sort module is accessible from ~/apps/admin/src/platform/gamification-admin/src/game-lib. If there are any issues with module resolution, consider updating the project configuration or verifying the directory structure.


import {
Display,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import {
import { sortBy } from 'lodash'

import { LoadingSpinner, PageTitle } from '~/libs/ui'
import { Sort } from '~/apps/gamification-admin/src/game-lib/pagination'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort has been updated. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the Sort module is available at this location. If the module has been moved or renamed, update the path accordingly.


import {
Display,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@
import React, { ChangeEvent } from 'react'

import { Button, IconOutline, InputSelect, InputText } from '~/libs/ui'
import { InputHandleAutocomplete, MembersAutocompeteResult } from '~/apps/gamification-admin/src/game-lib'
import {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the necessary files are present in the new location.

InputHandleAutocomplete,
MembersAutocompeteResult,
} from '~/apps/admin/src/platform/gamification-admin/src/game-lib'

import styles from './FilterBar.module.scss'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import React, { ChangeEvent } from 'react'

import { Button, InputSelect, InputText } from '~/libs/ui'
import { InputHandleAutocomplete, MembersAutocompeteResult } from '~/apps/gamification-admin/src/game-lib'
import { InputHandleAutocomplete, MembersAutocompeteResult } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path has been updated to reflect the new directory structure. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the files are accessible from this location. If the path is incorrect, it may lead to module resolution errors.


import styles from './FilterBar.module.scss'

Expand Down
2 changes: 1 addition & 1 deletion src/libs/ui/lib/components/table/Table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ import { Dispatch, SetStateAction, useEffect, useMemo, useRef, useState } from '
import _ from 'lodash'
import classNames from 'classnames'

import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort has been updated. Ensure that the new path ~/apps/admin/src/platform/gamification-admin/src/game-lib is correct and that the Sort module is available at this location.

import { useWindowSize, WindowSize } from '~/libs/shared'

import { Button } from '../button'
import { Sort } from '../../../../../apps/gamification-admin/src/game-lib/pagination'
import { IconOutline } from '../svgs'
import { Tooltip } from '../tooltip'
import '../../styles/_includes.scss'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Sort } from '../../../../../../apps/gamification-admin/src/game-lib/pagination'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'

import { TableColumn } from '../table-column.model'

export function getDefaultSort<T>(columns: ReadonlyArray<TableColumn<T>>, initSort?: Sort): Sort {
Expand Down
3 changes: 2 additions & 1 deletion src/libs/ui/lib/components/table/table-sort/TableSort.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { FC, SVGProps } from 'react'
import classNames from 'classnames'

import { Sort } from '../../../../../../apps/gamification-admin/src/game-lib/pagination'
import { Sort } from '~/apps/admin/src/platform/gamification-admin/src/game-lib'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The import path for Sort seems unnecessarily long and complex. Consider simplifying the directory structure or using an alias for better readability and maintainability.


import { IconOutline } from '../../svgs'
import { Button } from '../../button'

Expand Down