Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

JSON and Spatial types need to be considered strings #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mng1dev
Copy link

@mng1dev mng1dev commented Apr 1, 2022

Problem

Json and spatial columns are sent as string record, but defined as object type in the catalog.
This causes a problem because targets expect an object record and not a string.

More details in #99

Proposed changes

The columns of JSON and Spatial types are defined with type ["null", "string"] in the catalog.

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

@Samira-El
Copy link
Contributor

Hi Vektor, thanks for the PR, the change makes sense to me.

The CI is failing, can you please cover this change with some extra unit/integration tests.

@ile-g
Copy link
Contributor

ile-g commented Dec 6, 2022

Hi team. It would be great to have this fix in.
The PR seems stale - can I help unblock this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants