Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

JSON and Spatial types need to be considered strings #101

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

JSON and Spatial types need to be considered strings #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9012ea2
JSON column type should be string instead of object
mangonea Mar 31, 2022
aab3d5e
Spatial Types should be considered strings as well
mng1dev Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tap_mysql/discover_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def schema_for_column(column): # pylint: disable=too-many-branches
result.multipleOf = 10 ** (0 - column.numeric_scale)

elif data_type in JSON_TYPES:
result.type = ['null', 'object']
result.type = ['null', 'string']

elif data_type in STRING_TYPES:
result.type = ['null', 'string']
Expand All @@ -290,7 +290,7 @@ def schema_for_column(column): # pylint: disable=too-many-branches
result.format = 'binary'

elif data_type in SPATIAL_TYPES:
result.type = ['null', 'object']
result.type = ['null', 'string']
result.format = 'spatial'

else:
Expand Down