Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): improve accessibility with targeted :focus-visible focus styles for non-pointer devices #796

Merged
merged 16 commits into from
Oct 23, 2023

docs: apply :focus-visible style to icon button components

7c8fe72
Select commit
Loading
Failed to load commit list.
Merged

feat(react): improve accessibility with targeted :focus-visible focus styles for non-pointer devices #796

docs: apply :focus-visible style to icon button components
7c8fe72
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project failed Oct 18, 2023 in 0s

71.35% (-0.41%) compared to d5089ed

View this Pull Request on Codecov

71.35% (-0.41%) compared to d5089ed

Details

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (d5089ed) 71.76% compared to head (7c8fe72) 71.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage   71.76%   71.35%   -0.41%     
==========================================
  Files         374      374              
  Lines        6243     6256      +13     
==========================================
- Hits         4480     4464      -16     
- Misses       1763     1792      +29     
Files Coverage Δ
packages/react/src/button/Button.js 75.00% <ø> (ø)
packages/react/src/button/styles.js 97.14% <100.00%> (+0.08%) ⬆️
packages/react/src/checkbox/Checkbox.js 55.55% <100.00%> (+2.61%) ⬆️
packages/react/src/checkbox/CheckboxControlBox.js 100.00% <100.00%> (ø)
packages/react/src/checkbox/styles.js 100.00% <100.00%> (ø)
packages/react/src/drawer/styles.js 100.00% <100.00%> (ø)
packages/react/src/menu/styles.js 70.83% <100.00%> (-1.17%) ⬇️
packages/react/src/modal/styles.js 100.00% <100.00%> (ø)
packages/react/src/pagination/PaginationItem.js 100.00% <ø> (ø)
packages/react/src/radio/RadioControlBox.js 100.00% <100.00%> (ø)
... and 10 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.