fix compose notification action not recreating MainActivity #4249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlag
approved these changes
Feb 18, 2024
| @@ -456,7 +456,7 @@ private static PendingIntent getStatusComposeIntent(Context context, Notificatio | |||
|
|
|||
| Intent composeIntent = MainActivity.composeIntent(context, composeOptions, account.getId(), body.getId(), (int)account.getId()); | |||
|
|
|||
| composeIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); | |||
| composeIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK); | |||
There was a problem hiding this comment.
I'd leave a comment in code why we do this
Tak
approved these changes
Feb 20, 2024
| @@ -456,7 +456,7 @@ private static PendingIntent getStatusComposeIntent(Context context, Notificatio | |||
|
|
|||
| Intent composeIntent = MainActivity.composeIntent(context, composeOptions, account.getId(), body.getId(), (int)account.getId()); | |||
|
|
|||
| composeIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); | |||
| composeIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK); | |||
connyduck
added a commit
that referenced
this pull request
Feb 23, 2024
While working on #4249 I noticed that quick replies also don't work as expected. The notification just stays in the sending state forever. There are actually 2 problems: - Notifications are sent in `NotificationFetcher` with the id of the Mastodon notification as tag and the current account id as id. The wrong notification id was forwarded to `SendStatusBroadcastReceiver` so it never had a chance of updating the notification. - Notifications containing an active remote input can't be cancelled (they just stop their animation when doing so). So instead I update the notification with info that the reply is being sent and have it dismiss automatically. I also tried replacing the original notification with the "sending" notification of `SendStatusService`, but that doesn't work because `Service.startForeground` doesn't have a tag parameter, only an id. --------- Co-authored-by: Willow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4247