add bigdecimal as dependency #277
Conversation
bigdecimal is no longer part of stdlib
| @@ -37,3 +37,7 @@ group :test do | |||
| gem 'launchy' | |||
| gem 'addressable', '~> 2.4' | |||
| end | |||
|
|
|||
| group :runtime do | |||
There was a problem hiding this comment.
I've never seen a runtime group, can you explain why it's necessary?
There was a problem hiding this comment.
It's just that this dependency is needed at runtime while other existing groups in the file are development and test, so creating a new group was necessary. Maybe your question is, does it need a group? No, it could live outside a group. I do use runtime group as it's easier to understand what is it needed for rather than having no group. Anyway, bundle install everything by default, one have to explicitly exclude a group.
It's also consistent with add_runtime_dependency vs add_development_dependency in the Gemspec.
Example:
- https://github.com/noraj/haiti/blob/master/Gemfile
- https://github.com/noraj/haiti/blob/77e948646383d7a92edf6664b7709a527fe21d2e/.github/workflows/ruby.yml#L24
- https://bundler.io/guides/groups.html
TL;DR: it's not necessary, just more elegant and make it easier to understand what teh dependency are used for.
bigdecimal is no longer part of the standard library since ruby 3.4
so this fix deprecation warning when running twitter-cldr on previous ruby versions and fix LoadError on ruby 3.4.
ref. https://docs.ruby-lang.org/en/3.4/NEWS_md.html