Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bigdecimal as dependency #277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

add bigdecimal as dependency #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,7 @@ group :test do
gem 'launchy'
gem 'addressable', '~> 2.4'
end

group :runtime do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen a runtime group, can you explain why it's necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just that this dependency is needed at runtime while other existing groups in the file are development and test, so creating a new group was necessary. Maybe your question is, does it need a group? No, it could live outside a group. I do use runtime group as it's easier to understand what is it needed for rather than having no group. Anyway, bundle install everything by default, one have to explicitly exclude a group.
It's also consistent with add_runtime_dependency vs add_development_dependency in the Gemspec.

Example:

TL;DR: it's not necessary, just more elegant and make it easier to understand what teh dependency are used for.

gem 'bigdecimal', '~> 3.1', '>= 3.1.9'
end