Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: suppress mypy errors in test suite that come from 3rd party packages #596

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

intgr
Copy link
Contributor

@intgr intgr commented Apr 23, 2024

djangorestframework-stubs CI was failing due to changes in django-stubs upstream.

This issue has bit us a few times in the past too. A suggestion was proposed in typeddjango/pytest-mypy-plugins#134 (comment) that should fix this once and for all, and we can remove hacks that I previously added in mypy.ini.

@intgr intgr changed the title Fix CI (maybe) Fix CI: suppress mypy errors in test suite that come from 3rd party packages Apr 23, 2024
@intgr intgr marked this pull request as ready for review April 23, 2024 13:27
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sobolevn sobolevn merged commit 71a6b53 into typeddjango:master Apr 24, 2024
12 checks passed
@intgr intgr deleted the fix-ci-again branch April 24, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants