Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI: suppress mypy errors in test suite that come from 3rd party packages #596

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Fix CI: suppress mypy errors in test suite that come from 3rd party packages #596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecde8e1
Fix CI (maybe)
intgr Apr 23, 2024
289c342
Fix CI (maybe)
intgr Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ jobs:
SETUPTOOLS_ENABLE_FEATURES=legacy-editable pip install -r ./requirements.txt

- name: Run tests
run: pytest
# Suppress errors from other packages due to https://github.com/typeddjango/pytest-mypy-plugins/issues/134
run: pytest --mypy-only-local-stub

stubtest:
timeout-minutes: 10
Expand Down
20 changes: 0 additions & 20 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,23 +23,3 @@ plugins =

[mypy.plugins.django-stubs]
django_settings_module = scripts.drf_tests_settings

# Suppress errors from site-packages due to https://github.com/typeddjango/pytest-mypy-plugins/issues/134
[mypy-uritemplate.*]
warn_unreachable = false

[mypy-yaml.*]
disallow_untyped_defs = false
disallow_incomplete_defs = false

[mypy-urllib3.*]
disallow_untyped_defs = false
disallow_incomplete_defs = false

[mypy-requests.*]
disallow_untyped_defs = false
disallow_incomplete_defs = false

[mypy-markdown.*]
disallow_untyped_defs = false
disallow_incomplete_defs = false