Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abg): use the release date of the latest version for lastUpdated #1612

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Vampire
Copy link
Collaborator

@Vampire Vampire commented Aug 19, 2024

This makes the metadata file content more stable and allows to provide a checksum,
as Kotlin for example is quite unhappy if it finds no checksum or cannot successfully verify it.

Without this every request would produce a different file and thus also a different checksum file,
so the checksum would never match the file contents.

Copy link
Collaborator Author

Vampire commented Aug 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Vampire and the rest of your teammates on Graphite Graphite

@krzema12
Copy link
Member

Can you show me how to reproduce Kotlin being unhappy by the lack of the checksum/release date? I experienced it for version-specific artifacts, but for this artifact I didn't.

@Vampire Vampire force-pushed the vampire/version-range-support branch from 5f291dc to 09633a4 Compare August 19, 2024 18:26
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from d81995e to bf447ca Compare August 19, 2024 18:28
@Vampire
Copy link
Collaborator Author

Vampire commented Aug 19, 2024

If you use a version range, it downloads the metadata file to get the list of versions and wants to validate it, then cries if it cannot.

@Vampire Vampire force-pushed the vampire/version-range-support branch from 09633a4 to cb4a8a3 Compare August 20, 2024 10:46
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from bf447ca to 8326892 Compare August 20, 2024 10:46
@Vampire Vampire force-pushed the vampire/version-range-support branch from cb4a8a3 to d9a036e Compare August 20, 2024 11:26
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from 8326892 to 3ece0b6 Compare August 20, 2024 11:26
@Vampire Vampire force-pushed the vampire/version-range-support branch from d9a036e to a7e496f Compare August 20, 2024 11:58
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from 3ece0b6 to a9e554c Compare August 20, 2024 12:00
@Vampire Vampire force-pushed the vampire/version-range-support branch from a7e496f to ef9782d Compare August 22, 2024 00:00
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from a9e554c to d594493 Compare August 22, 2024 00:00
@Vampire Vampire force-pushed the vampire/version-range-support branch from 65de8a3 to 46fb8ff Compare August 26, 2024 16:13
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from 2a83493 to e2d2901 Compare August 26, 2024 16:13
@Vampire Vampire force-pushed the vampire/version-range-support branch from 46fb8ff to 109d975 Compare August 26, 2024 16:34
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from e2d2901 to 380bdea Compare August 26, 2024 16:34
@Vampire Vampire force-pushed the vampire/version-range-support branch from 109d975 to 3f8d009 Compare August 26, 2024 17:11
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from 380bdea to 1ce27b6 Compare August 26, 2024 17:11
@krzema12 krzema12 force-pushed the vampire/version-range-support branch from 3f8d009 to 2ea0adb Compare August 31, 2024 17:21
@krzema12 krzema12 force-pushed the vampire/latest-release-date-in-maven-metadata branch from 1ce27b6 to dcb2ca5 Compare August 31, 2024 17:22
@Vampire Vampire force-pushed the vampire/version-range-support branch from 2ea0adb to f0cc02e Compare August 31, 2024 17:49
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from dcb2ca5 to a72b66b Compare August 31, 2024 17:49
@Vampire Vampire force-pushed the vampire/version-range-support branch from f0cc02e to 12c3675 Compare September 4, 2024 00:28
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from a72b66b to e8c1cd5 Compare September 4, 2024 00:28
@Vampire Vampire force-pushed the vampire/version-range-support branch from 12c3675 to f7c8535 Compare September 4, 2024 23:06
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from e8c1cd5 to 2574b9d Compare September 4, 2024 23:06
@Vampire Vampire force-pushed the vampire/version-range-support branch from f7c8535 to 851c826 Compare September 5, 2024 18:48
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from 2574b9d to bbbeee6 Compare September 5, 2024 18:48
@Vampire Vampire changed the title fix(abg): Use the release date of the latest version for lastUpdated fix(abg): use the release date of the latest version for lastUpdated Sep 5, 2024
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from bbbeee6 to 715b8df Compare September 5, 2024 21:38
@Vampire Vampire force-pushed the vampire/version-range-support branch from 851c826 to 779b608 Compare September 6, 2024 18:44
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from 715b8df to 7d6a173 Compare September 6, 2024 18:44
@Vampire Vampire force-pushed the vampire/version-range-support branch from 779b608 to a7694a5 Compare September 8, 2024 08:10
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from 7d6a173 to 39cda66 Compare September 8, 2024 08:11
@Vampire Vampire changed the base branch from vampire/version-range-support to main September 8, 2024 08:11
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from 39cda66 to 7ca0c8f Compare September 8, 2024 09:20
@Vampire Vampire force-pushed the vampire/latest-release-date-in-maven-metadata branch from 7ca0c8f to c741439 Compare September 8, 2024 20:26
Copy link
Member

krzema12 commented Sep 9, 2024

Merge activity

@krzema12 krzema12 merged commit 34e7d40 into main Sep 9, 2024
18 checks passed
@krzema12 krzema12 deleted the vampire/latest-release-date-in-maven-metadata branch September 9, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants