Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(abg): create JARs only when they are actually requested #1615

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

Vampire
Copy link
Collaborator

@Vampire Vampire commented Aug 20, 2024

In some cases, only e.g. a POM is necessary to fetch for a given action. Thanks to this change, no Kotlin compilation or JAR creation will happen when requesting an artifact that doesn't require it.

Copy link
Collaborator Author

Vampire commented Aug 20, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Vampire and the rest of your teammates on Graphite Graphite

@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from 08293c4 to e888756 Compare August 20, 2024 10:46
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from 9b85609 to f4e253b Compare August 20, 2024 10:46
@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from e888756 to 748f7ac Compare August 20, 2024 11:27
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from f4e253b to bd4ecb7 Compare August 20, 2024 11:27
@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from 748f7ac to 084ba53 Compare August 20, 2024 12:01
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from bd4ecb7 to 57aefbd Compare August 20, 2024 12:02
@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from 084ba53 to af4c964 Compare August 22, 2024 00:01
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from 57aefbd to 23eab1b Compare August 22, 2024 00:01
@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from af4c964 to 4f1ca6a Compare August 22, 2024 00:27
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from 23eab1b to b99bf8e Compare August 22, 2024 00:27
@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from 4f1ca6a to 01bfd2c Compare August 22, 2024 01:10
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from b99bf8e to d909c4e Compare August 22, 2024 01:10
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from b3c62ce to 527c76a Compare August 26, 2024 17:12
@krzema12 krzema12 force-pushed the vampire/prefix-temp-dirs branch from 4be4e64 to ee7d17c Compare August 31, 2024 17:23
@krzema12 krzema12 force-pushed the vampire/lazy-jar-creation branch from 527c76a to 35bff5a Compare August 31, 2024 17:24
@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from ee7d17c to 236983f Compare August 31, 2024 17:49
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from 35bff5a to b0049d7 Compare August 31, 2024 17:49
@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from 236983f to 9c6721a Compare September 4, 2024 00:28
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from b0049d7 to 28d8de9 Compare September 4, 2024 00:28
@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from 9c6721a to 88841f3 Compare September 4, 2024 23:06
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from 28d8de9 to 49ccdad Compare September 4, 2024 23:06
@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from 88841f3 to 94a180c Compare September 5, 2024 18:48
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from 49ccdad to c988e74 Compare September 5, 2024 18:48
@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from 94a180c to 7c554ae Compare September 5, 2024 21:38
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from c988e74 to 90814cf Compare September 5, 2024 21:38
@Vampire Vampire force-pushed the vampire/prefix-temp-dirs branch from 7c554ae to 69a4815 Compare September 6, 2024 18:45
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch 2 times, most recently from da86cc7 to f173834 Compare September 8, 2024 08:09
@Vampire Vampire changed the base branch from vampire/prefix-temp-dirs to main September 8, 2024 08:10
@Vampire Vampire requested a review from krzema12 September 8, 2024 20:27
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch 3 times, most recently from 7d05583 to 6955515 Compare September 9, 2024 10:54
@Vampire Vampire force-pushed the vampire/lazy-jar-creation branch from 6955515 to 6e2e4fc Compare September 10, 2024 16:39
@krzema12 krzema12 changed the title feat(abg): only create sources and jars when they are actually requested f(abg): only create sources and jars when they are actually requested Sep 18, 2024
@krzema12 krzema12 changed the title f(abg): only create sources and jars when they are actually requested perf(abg): create JARs only when they are actually requested Sep 18, 2024
@krzema12 krzema12 merged commit a112e28 into main Sep 18, 2024
18 checks passed
@krzema12 krzema12 deleted the vampire/lazy-jar-creation branch September 18, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants