Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stricter typescript settings and some cleanup. #3910

Merged
merged 7 commits into from
Dec 26, 2024
Merged

Conversation

Goldziher
Copy link
Collaborator

This PR does the following:

1- Update the root tsconfig.json file to have stricter settings.
2- Fix ensuing build issues.
3. Update the web app tsconfigs as well.

Why? Better to seperate this stuff out of the pnpm branch.

Copy link

codesandbox bot commented Dec 24, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Dec 24, 2024

⚠️ No Changeset found

Latest commit: c30304b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Goldziher Goldziher requested a review from zbeyens December 24, 2024 21:56
Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 10:40am

tsconfig.json Outdated Show resolved Hide resolved
Co-authored-by: Na'aman Hirschfeld <[email protected]>
@zbeyens zbeyens merged commit 69f4f72 into main Dec 26, 2024
8 checks passed
@zbeyens zbeyens deleted the improve-ts branch December 26, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants