-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Update SRW reference chapter #1184
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the updates from the Technical-FAQs site to the SRW App's documentation!
I do have two concerns:
- The
.. _AddPhys:
entry on line 209 should be moved down to after the newly added frequently asked questions so that it matches up with the add physics scheme FAQ. - The
devclean.sh
convenience script has changed and--clean
is no longer an option. I have provided a suggested change for this FAQ entry.
Following these modifications, I should be able to provide my approval to for this PR.
The failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying the modifications related to the devclean.sh
convenience script! The updates look good to me, so I will go ahead and approve these now.
@@ -21,7 +21,7 @@ Quick Start Guide (SRW-AQM) | |||
|
|||
.. attention:: | |||
|
|||
These instructions should work smoothly on Hera and WCOSS2, but users on other systems may need to make additional adjustments. | |||
These instructions should work smoothly on Hera, Hercules, Derecho and Orion but users on other systems may need to make additional adjustments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing comma after Derecho
Update develop to head at ufs-community
Use this template to give a detailed message describing the change you want to make to the code.
You may delete any sections labeled "optional" and any instructions within .
If you are unclear on what should be written here, see https://github.com/wrf-model/WRF/wiki/Making-a-good-pull-request-message for some guidance and review the Code Contributor's Guide at https://github.com/ufs-community/ufs-srweather-app/wiki/Code-Manager's-Guide.
Code reviewers will assess the PR based on the criteria laid out in the Code Reviewer's Guide (https://github.com/ufs-community/ufs-srweather-app/wiki/Code-Manager's-Guide).
The title of this pull request should be a brief summary (ideally less than 100 characters) of the changes included in this PR. Please also include the branch to which this PR is being issued (e.g., "[develop]: Updated UFS_UTILS hash").
Use the "Preview" tab to see what your PR will look like when you hit "Create pull request"
--- Delete this line and those above before hitting "Create pull request" ---
DESCRIPTION OF CHANGES:
Type of change
TESTS CONDUCTED:
DEPENDENCIES:
DOCUMENTATION:
ISSUE:
CHECKLIST
LABELS (optional):
A Code Manager needs to add the following labels to this PR:
CONTRIBUTORS (optional):