-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-18245 Generate cldr-json 47.0.0-ALPHA1 and ALPHA2 #81
base: main
Are you sure you want to change the base?
Conversation
-Built with cldr tags/release-47-alpha1 -Built with cldr-staging tags/release-47-alpha1 (downloaded as cldr-staging-release-47-alpha1.tar.gz)
@srl295 how does this look? Should I do cldr-generate-zip.sh now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks ready to generate data!
@@ -35,17 +36,17 @@ Make sure your `cldr-json` directory is otherwise clean (`git status`) | |||
|
|||
### Updating the Repository | |||
|
|||
1. Run `git checkout -b ...` to create a new branch. | |||
1. Run `git checkout -b ...` to create a new branch. Typical practice is to create a new branch for a major version, such as `v44`, and only merge it back to `main` upon release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes to UPDATING.md are very helpful! In the context of this PR, the history is confusing. Changes to UPDATING.md are actually from a different PR, already merged, #71
"full": "HHmmsszzzz", | ||
"long": "HHmmssz", | ||
"medium": "HHmmss", | ||
"short": "HHmm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little surprised at how many changes there are from alpha1 to alpha2. These changes to en-GS appear to be from unicode-org/cldr#4320 last week.
@srl295 I'll wait for your go-ahead to do cldr-generate-zip.sh and tag a release for alpha2 |
Looks good - the zip is needed so icu4x can test before going to npm |
Here it is: https://github.com/unicode-org/cldr-json/releases/tag/47.0.0-ALPHA2 About npm: when do we publish on npm? alpha1, alpha2, ...? We haven't published alpha1 on npm |
-Built with cldr tags/release-47-alpha1 (or alpha2 for the 2nd commit, see further comments below)
-Built with cldr-staging tags/release-47-alpha1 (downloaded as cldr-staging-release-47-alpha1.tar.gz) (or alpha2 for 2nd commit)