Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18279 Generate cldr-json 47.0.0-ALPHA2 #82

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Feb 3, 2025

-Built with cldr tags/release-47-alpha2

-Built with cldr-staging tags/release-47-alpha2 (downloaded as cldr-staging-release-47-alpha2.tar.gz)

-Built with cldr tags/release-47-alpha2

-Built with cldr-staging tags/release-47-alpha2 (downloaded as cldr-staging-release-47-alpha2.tar.gz)
@btangmu btangmu self-assigned this Feb 3, 2025
@btangmu btangmu requested a review from srl295 February 3, 2025 21:03
@srl295
Copy link
Member

srl295 commented Feb 3, 2025

@btangmu
Copy link
Member Author

btangmu commented Feb 4, 2025

  • could just add commits to the same branch

OK, I've done that. See the 2nd commit on #81

There are a lot of differences of procedure between cldr and cldr-json, in terms of how we use tickets, PRs, and release tags. It's starting to make sense... Next time, I guess I would not make separate tickets or branches or PRs for alpha1/alpha2/beta1/beta2/... How about release candidates, should those stay on the same ticket/branch/PR, until finally getting merged into main?

@srl295
Copy link
Member

srl295 commented Feb 5, 2025

  • could just add commits to the same branch

OK, I've done that. See the 2nd commit on #81

There are a lot of differences of procedure between cldr and cldr-json, in terms of how we use tickets, PRs, and release tags.

it's a data repo, so it's a lot more like cldr-staging in that regard.

It's starting to make sense... Next time, I guess I would not make separate tickets or branches or PRs for alpha1/alpha2/beta1/beta2/... How about release candidates, should those stay on the same ticket/branch/PR, until finally getting merged into main?

I usually make one PR and branch for (and named) say v44 and keep updating that, tagging from it, and then merge it into main on release.

That way , the PR shows 'what changed' since the previous version, and each commit shows what changed in the different alpha/beta tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants