-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bevy 0.15 #85
base: main
Are you sure you want to change the base?
Conversation
I'm explicitely not porting over the |
when i use your fork i still get the panic
and it might NOT be from this crate but im thinking it is -- bc it only happens when this xform gizmo state is being changed |
Interesting, I've used this project in |
@ActuallyHappening Unfortunately, I just encountered the same error in your crate. I think something may be changed mistakenly. Please see the following logs:
I am using a very lightly modified version of the crate to make it compile. It only changes the |
Yeah OK so this line seems to be the culprit, idk why and can't reproduce this bug so can't really help sorry 🤷 pass.set_index_buffer(gizmo.index_buffer.slice(..), 0, IndexFormat::Uint32); |
i was able to fix the bug !! here is how . thanks for the tip actuallyhappening
SO basically it seems like however i am integrating the gizmo, when i deselect it, the gizmo component gets into a state where it exists but it also has an empty index buffer. I am not sure why but anyways the code above makes it much safer ^ |
I remember thinking to myself that problem may surface with the way if let Some(thing) = source.get() {
// safe here
} instead of manual length checks. |
These changes support bevy 0.15.
I couldn't find any bugs except a random
#[cfg(feature = "webgl")]
that doesn't seem to actually exist, which I just commented out and don't think will make any difference (as it couldn't have been enabled before without manually passing--cfg="feature='webgl'"
on the command line.Could this get a crates-io release soon? I'm trying to port over bevy-editor-pls: jakobhellermann/bevy_editor_pls#118