Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Median Multipliers Not Showing #61

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix Median Multipliers Not Showing #61

merged 2 commits into from
Dec 13, 2023

Conversation

vkoves
Copy link
Owner

@vkoves vkoves commented Dec 6, 2023

Description

Fixes the city wide and property specific median multipliers not showing up (e.g. this building burned 4x the median natural gas). Here's a demo from Keating with the medians outlined:

Screenshot from 2023-12-05 21-14-24

Fixes #54

Testing Instructions

Validated the median multipliers show up and are sound, and that old buildings (like United Center or the Art Institute) still work.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vkoves vkoves added the bug Something isn't working label Dec 6, 2023
Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for radiant-cucurucho-d09bae ready!

Name Link
🔨 Latest commit de34c4d
🔍 Latest deploy log https://app.netlify.com/sites/radiant-cucurucho-d09bae/deploys/656fe78c1ec47e000817f6dd
😎 Deploy Preview https://deploy-preview-61--radiant-cucurucho-d09bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@alexkcode alexkcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and checked test cases for different multiplier renderings.

@alexkcode alexkcode merged commit df985e9 into main Dec 13, 2023
6 checks passed
@alexkcode alexkcode deleted the fix-median branch December 13, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Median Multiplier Is Missing
2 participants