Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Median Multipliers Not Showing #61

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Fix Median Multipliers Not Showing #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e14f549
Fixed city wide median not rendering
vkoves Dec 6, 2023
de34c4d
Fix property type median
vkoves Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/components/StatTile.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@
class="median-comparison"
>
<div>
<!-- Only show median multiple if value is > 0, otherwise it's 1/infinity -->
<!-- Only show median multiple if the building stat is > 0, otherwise it's 1/infinity -->
<span
v-if="stats[statKey] > 0"
v-if="statValue !== '0'"
class="val"
>
{{ medianMultipleMsgCityWide }} median
Expand All @@ -113,9 +113,9 @@
</div>

<div v-if="medianMultiplePropertyType">
<!-- Only show median multiple if value is > 0, otherwise it's 1/infinity -->
<!-- Only show median multiple if the building stat is > 0, otherwise it's 1/infinity -->
<span
v-if="stats[statKey] > 0"
v-if="statValue !== '0'"
class="val"
>
{{ medianMultiplePropertyType }} median {{ propertyType }}
Expand Down Expand Up @@ -223,7 +223,6 @@ export default class StatTile extends Vue {
return this.building["PrimaryPropertyType"];
}


/**
* Whether a building is _fully_ gas free, meaning no natural gas burned on-site or to heat it
* through a district heating system.
Expand Down