feat: introduce subscription manager #2202
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Logic that is handling specifics of subscription such as: pings, peers, events, cache.
Was spread between classes: Subscription, Reliability monitors etc.
Solution
This PR encapsulates everything (apart from
LightPush
check) intoSubsriptionMonitor
that is a substitute build on top ofReliabilityMonitor
. This new entity enclosed inSubscription
module and private to it.Notes
LightPush
checks will be a separate feature PR as it increases friction without giving much benefit at this stage - follow up to scope in #2203This PR is second to #2193