Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce subscription manager #2202

Open
wants to merge 1 commit into
base: weboko/filter-subscription
Choose a base branch
from

Conversation

weboko
Copy link
Collaborator

@weboko weboko commented Jan 14, 2025

Problem

Logic that is handling specifics of subscription such as: pings, peers, events, cache.
Was spread between classes: Subscription, Reliability monitors etc.

Solution

This PR encapsulates everything (apart from LightPush check) into SubsriptionMonitor that is a substitute build on top of ReliabilityMonitor. This new entity enclosed in Subscription module and private to it.

Notes

LightPush checks will be a separate feature PR as it increases friction without giving much benefit at this stage - follow up to scope in #2203

This PR is second to #2193

@weboko weboko requested a review from a team as a code owner January 14, 2025 22:43
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 84.03 KB (-0.81% 🔽) 1.7 s (-0.81% 🔽) 1.3 s (+4.71% 🔺) 2.9 s
Waku Simple Light Node 134.23 KB (-0.69% 🔽) 2.7 s (-0.69% 🔽) 1.7 s (-8.88% 🔽) 4.4 s
ECIES encryption 22.88 KB (0%) 458 ms (0%) 856 ms (+104.87% 🔺) 1.4 s
Symmetric encryption 22.37 KB (0%) 448 ms (0%) 535 ms (+35.1% 🔺) 982 ms
DNS discovery 70.49 KB (0%) 1.5 s (0%) 1.2 s (+8.36% 🔺) 2.6 s
Peer Exchange discovery 71.47 KB (0%) 1.5 s (0%) 1.3 s (+15.24% 🔺) 2.8 s
Local Peer Cache Discovery 65.08 KB (0%) 1.4 s (0%) 1.2 s (+10.71% 🔺) 2.5 s
Privacy preserving protocols 76.07 KB (-0.1% 🔽) 1.6 s (-0.1% 🔽) 1.3 s (+61.91% 🔺) 2.8 s
Waku Filter 77.55 KB (-1.31% 🔽) 1.6 s (-1.31% 🔽) 981 ms (-31.9% 🔽) 2.6 s
Waku LightPush 75.17 KB (+0.03% 🔺) 1.6 s (+0.03% 🔺) 977 ms (-4.15% 🔽) 2.5 s
History retrieval protocols 75.23 KB (-0.03% 🔽) 1.6 s (-0.03% 🔽) 770 ms (-24.15% 🔽) 2.3 s
Deterministic Message Hashing 7.39 KB (0%) 148 ms (0%) 206 ms (+16.46% 🔺) 354 ms

@danisharora099
Copy link
Collaborator

can we address #2193 before we review this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants