feat: introduce subscription manager

.github/workflows/ci.yml

@@ -57,7 +57,7 @@ jobs:
   browser:
     runs-on: ubuntu-latest
     container:
-      image: mcr.microsoft.com/playwright:v1.48.0-jammy
+      image: mcr.microsoft.com/playwright:v1.50.0-jammy
     env:
       HOME: "/root"
     steps:

.github/workflows/playwright.yml

@@ -20,7 +20,7 @@ jobs:
     timeout-minutes: 60
     runs-on: ubuntu-latest
     container:
-      image: mcr.microsoft.com/playwright:v1.48.0-jammy
+      image: mcr.microsoft.com/playwright:v1.50.0-jammy
     steps:
     - uses: actions/checkout@v3
     - uses: actions/setup-node@v3

packages/browser-tests/package.json

@@ -11,7 +11,7 @@
     "test": "npx playwright test"
   },
   "devDependencies": {
-    "@playwright/test": "^1.48.1",
+    "@playwright/test": "^1.50.0",
     "@waku/create-app": "^0.1.1-504bcd4",
     "dotenv-flow": "^4.1.0",
     "serve": "^14.2.3"

packages/sdk/src/protocols/filter/constants.ts

@@ -1,4 +1,3 @@
 export const DEFAULT_KEEP_ALIVE = 60_000;
 export const DEFAULT_MAX_PINGS = 3;
 export const DEFAULT_LIGHT_PUSH_FILTER_CHECK = false;
-export const DEFAULT_LIGHT_PUSH_FILTER_CHECK_INTERVAL = 10_000;

packages/sdk/src/protocols/filter/index.ts

@@ -8,7 +8,6 @@ import type {
   IDecoder,
   IFilter,
   ILightPush,
-  IProtoMessage,
   Libp2p,
   PubsubTopic,
   SubscribeResult,
@@ -25,7 +24,6 @@ import {
 
 import { PeerManager } from "../peer_manager.js";
 
-import { MessageCache } from "./message_cache.js";
 import { Subscription } from "./subscription.js";
 import { buildConfig } from "./utils.js";
 
@@ -35,7 +33,6 @@ class Filter implements IFilter {
   public readonly protocol: FilterCore;
 
   private readonly config: FilterProtocolOptions;
-  private readonly messageCache: MessageCache;
   private activeSubscriptions = new Map<string, Subscription>();
 
   public constructor(
@@ -46,7 +43,6 @@ class Filter implements IFilter {
     config?: Partial<FilterProtocolOptions>
   ) {
     this.config = buildConfig(config);
-    this.messageCache = new MessageCache(libp2p);
 
     this.protocol = new FilterCore(
       async (pubsubTopic, wakuMessage, peerIdStr) => {
@@ -58,14 +54,6 @@ class Filter implements IFilter {
           return;
         }
 
-        if (this.messageCache.has(pubsubTopic, wakuMessage as IProtoMessage)) {
-          log.info(
-            `Skipping duplicate message for pubsubTopic:${pubsubTopic} peerId:${peerIdStr}`
-          );
-          return;
-        }
-
-        this.messageCache.set(pubsubTopic, wakuMessage as IProtoMessage);
         await subscription.processIncomingMessage(wakuMessage, peerIdStr);
       },