-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump dependencies for v0.35 #3096
Conversation
You can find the image built from this PR at
Built from 51bd18e |
dd30711
to
7f1ea08
Compare
Can I review or do the tests need fixing first? @NagyZoltanPeter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
var events = newJArray() | ||
for eventStr in eventStrs: | ||
events.add(parseJson($eventStr)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know where the dollar come from. But to be on safe side:
var events = newJArray()
for eventStr in eventStrs:
events.add(parseJson(eventStr.string))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably I overlooked it as a leftover here. Thanks for it.
Bump nim-web3, nim-eth and deps - on_chain/group_manager.nim adaption Added status-im/nim-minilru submodule required by latest nim-eth Added nim-quic and nim-ngtcp2 as new deps of nim-libp2p Fixing tests. Changes: modified: .gitmodules modified: tests/waku_discv5/utils.nim modified: tests/waku_enr/utils.nim modified: tests/waku_rln_relay/test_rln_group_manager_onchain.nim modified: tests/waku_rln_relay/utils.nim modified: tests/waku_rln_relay/utils_onchain.nim modified: vendor/nim-chronicles modified: vendor/nim-eth modified: vendor/nim-http-utils modified: vendor/nim-json-rpc modified: vendor/nim-json-serialization modified: vendor/nim-libp2p modified: vendor/nim-metrics new file: vendor/nim-minilru modified: vendor/nim-nat-traversal new file: vendor/nim-ngtcp2 modified: vendor/nim-presto new file: vendor/nim-quic modified: vendor/nim-secp256k1 modified: vendor/nim-serialization modified: vendor/nim-stew modified: vendor/nim-taskpools modified: vendor/nim-testutils modified: vendor/nim-toml-serialization modified: vendor/nim-unicodedb modified: vendor/nim-unittest2 modified: vendor/nim-web3 modified: vendor/nim-websock modified: vendor/nim-zlib modified: vendor/nimcrypto modified: waku.nimble modified: waku/common/enr/builder.nim modified: waku/common/enr/typed_record.nim modified: waku/common/utils/nat.nim modified: waku/discovery/waku_discv5.nim modified: waku/waku_rln_relay/conversion_utils.nim modified: waku/waku_rln_relay/group_manager/on_chain/group_manager.nim modified: waku/waku_rln_relay/rln/wrappers.nim modified: waku/waku_rln_relay/rln_relay.nim
…ting import from json_rpc instead of using std/json
…ction success in register
b5df2ce
to
e2baa74
Compare
This PR may contain changes to database schema of one of the drivers. If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues. Please make sure the label |
As original vendor bumps for v0.34.0 was postponed (yet partially done only) this PR can be closed. cc: @Ivansete-status |
Description
Prepare for v0.35.0
Bumping versions of vendor libs.
Main feature is bumping nim-web3 (and dependencies), nim-eth changes, long time had not been elevated.
This involved due to dependent changes to make json-rpc up to date as well.
By updating nim-libp2p we needed to add nim-quic and nim-ngtcp2 submodules.
Changes
Due to the huge refactorings in nim-web3 and nim-eth modules:
Code changes:
Test changes:
Issue
#3087