Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix private access example #155

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

flamarion
Copy link
Contributor

fix: Fix private access example

@flamarion flamarion requested a review from gls4 as a code owner December 1, 2023 08:56
@flamarion flamarion requested a review from a team December 1, 2023 08:56
@flamarion flamarion merged commit f0745ea into main Dec 7, 2023
7 checks passed
@flamarion flamarion deleted the fix_private_access_example branch December 7, 2023 16:57
jsbroks pushed a commit that referenced this pull request Dec 7, 2023
### [3.4.1](v3.4.0...v3.4.1) (2023-12-07)

### Bug Fixes

* Fix private access example ([#155](#155)) ([f0745ea](f0745ea))
@jsbroks
Copy link
Member

jsbroks commented Dec 7, 2023

This PR is included in version 3.4.1 🎉

@@ -61,18 +61,19 @@ module "standard" {
namespace = var.namespace
public_access = false

wandb_license = var.wandb_license
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's prolly worth keeping the license, the variable can be set to "" if the user does not have one yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants