Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix private access example #155

Merged
merged 2 commits into from
Dec 7, 2023
Merged

fix: Fix private access example #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1730ece
fix: Fix private access example
flamarion Dec 1, 2023
568d169
Remove test configuration
flamarion Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions examples/private-access-only/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,18 +61,19 @@ module "standard" {
namespace = var.namespace
public_access = false

wandb_license = var.wandb_license
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's prolly worth keeping the license, the variable can be set to "" if the user does not have one yet.


domain_name = aws_route53_zone.private.name
zone_id = aws_route53_zone.private.zone_id

# Creating a custom VPC so that we can initalize a route53 zone first and configure a vpn
create_vpc = false
network_id = module.networking.vpc_id
network_private_subnets = module.networking.private_subnets
network_public_subnets = module.networking.public_subnets
create_vpc = false
network_id = module.networking.vpc_id
network_private_subnets = module.networking.private_subnets
network_public_subnets = module.networking.public_subnets
allowed_inbound_cidr = var.allowed_inbound_cidr
allowed_inbound_ipv6_cidr = var.allowed_inbound_ipv6_cidr
eks_cluster_version = var.eks_cluster_version
}

output "url" {
value = module.standard.url
}
}
19 changes: 17 additions & 2 deletions examples/private-access-only/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,22 @@ variable "namespace" {
description = "Name prefix used for resources"
}

variable "wandb_license" {
type = string
variable "allowed_inbound_cidr" {
default = ["0.0.0.0/0"]
nullable = false
type = list(string)
}


variable "allowed_inbound_ipv6_cidr" {
default = ["::/0"]
nullable = false
type = list(string)
}

variable "eks_cluster_version" {
description = "EKS cluster kubernetes version"
default = "1.26"
nullable = false
type = string
}
4 changes: 2 additions & 2 deletions examples/private-access-only/versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ terraform {
required_providers {
aws = {
source = "hashicorp/aws"
version = "~> 3.60"
version = "~> 4.0"
}
}
}
}
Loading